Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
89feaca2
Commit
89feaca2
authored
Mar 28, 2005
by
Marcus Meissner
Committed by
Alexandre Julliard
Mar 28, 2005
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixed ppvObject serializer (deref twice instead of once).
Actually pass back return value of remote call in type marshaller.
parent
40224b6e
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
19 additions
and
8 deletions
+19
-8
tmarshal.c
dlls/oleaut32/tmarshal.c
+19
-8
No files found.
dlls/oleaut32/tmarshal.c
View file @
89feaca2
...
...
@@ -898,13 +898,13 @@ serialize_LPVOID_ptr(
FIXME
(
"ppvObject not expressed as VT_PTR -> VT_PTR -> VT_VOID?
\n
"
);
return
E_FAIL
;
}
cookie
=
(
*
arg
)
?
0x42424242
:
0x0
;
cookie
=
(
*
(
DWORD
*
)
*
arg
)
?
0x42424242
:
0x0
;
if
(
writeit
)
{
hres
=
xbuf_add
(
buf
,
(
LPVOID
)
&
cookie
,
sizeof
(
cookie
));
if
(
hres
)
return
hres
;
}
if
(
!*
arg
)
{
if
(
!*
(
DWORD
*
)
*
arg
)
{
if
(
debugout
)
TRACE_
(
olerelay
)(
"<lpvoid NULL>"
);
return
S_OK
;
}
...
...
@@ -1470,6 +1470,7 @@ xCall(LPVOID retptr, int method, TMProxyImpl *tpinfo /*, args */)
BSTR
names
[
10
];
int
nrofnames
;
int
is_idispatch_getidsofnames
=
0
;
DWORD
remoteresult
=
0
;
EnterCriticalSection
(
&
tpinfo
->
crit
);
...
...
@@ -1618,7 +1619,7 @@ afterserialize:
return
hres
;
}
if
(
relaydeb
)
TRACE_
(
olerelay
)(
" = %08lx ("
,
status
);
if
(
relaydeb
)
TRACE_
(
olerelay
)(
"
status
= %08lx ("
,
status
);
if
(
buf
.
base
)
buf
.
base
=
HeapReAlloc
(
GetProcessHeap
(),
0
,
buf
.
base
,
msg
.
cbBuffer
);
else
...
...
@@ -1645,6 +1646,7 @@ afterserialize:
/* generic deserializer using typelib description */
xargs
=
args
;
status
=
S_OK
;
for
(
i
=
0
;
i
<
fdesc
->
cParams
;
i
++
)
{
ELEMDESC
*
elem
=
fdesc
->
lprgelemdescParam
+
i
;
BOOL
isdeserialized
=
FALSE
;
...
...
@@ -1714,12 +1716,17 @@ afterserialize:
xargs
+=
_argsize
(
elem
->
tdesc
.
vt
);
}
after_deserialize:
if
(
relaydeb
)
TRACE_
(
olerelay
)(
")
\n
"
);
HeapFree
(
GetProcessHeap
(),
0
,
buf
.
base
);
hres
=
xbuf_get
(
&
buf
,
(
LPBYTE
)
&
remoteresult
,
sizeof
(
DWORD
));
if
(
hres
!=
S_OK
)
return
hres
;
if
(
relaydeb
)
TRACE_
(
olerelay
)(
") = %08lx
\n
"
,
remoteresult
);
LeaveCriticalSection
(
&
tpinfo
->
crit
);
if
(
status
!=
S_OK
)
/* OLE/COM internal error */
return
status
;
return
status
;
HeapFree
(
GetProcessHeap
(),
0
,
buf
.
base
);
LeaveCriticalSection
(
&
tpinfo
->
crit
);
return
remoteresult
;
}
HRESULT
WINAPI
ProxyIUnknown_QueryInterface
(
IUnknown
*
iface
,
REFIID
riid
,
void
**
ppv
)
...
...
@@ -2137,11 +2144,15 @@ afterdeserialize:
}
}
afterserialize:
hres
=
xbuf_add
(
&
buf
,
(
LPBYTE
)
&
res
,
sizeof
(
DWORD
));
if
(
hres
!=
S_OK
)
return
hres
;
/* might need to use IRpcChannelBuffer_GetBuffer ? */
xmsg
->
cbBuffer
=
buf
.
curoff
;
xmsg
->
Buffer
=
buf
.
base
;
HeapFree
(
GetProcessHeap
(),
0
,
args
);
return
res
;
return
S_OK
;
}
static
LPRPCSTUBBUFFER
WINAPI
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment