IsRectEmpty also returns true for negative width/heights (verified

against Windows), found by Brad Oliver <bradman@pobox.com>.

IsRectEmpty also returns true for negative width/heights (verified
8c45e243 · Marcus Meissner · Alexandre Julliard · a18fc8a7 · 8c45e243
Commit 8c45e243 authored Mar 09, 2000 by Marcus Meissner Committed by Alexandre Julliard Mar 09, 2000
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 2 deletions

rect.c windows/rect.c +6 -2

No files found.
--- a/windows/rect.c
+++ b/windows/rect.c
@@ -80,19 +80,23 @@ BOOL WINAPI CopyRect( RECT *dest, const RECT *src )

 /***********************************************************************
 *           IsRectEmpty16    (USER.75)
+ *
+ * Bug compat: Windows checks for 0 or negative width/height.
 */
 BOOL16 WINAPI IsRectEmpty16( const RECT16 *rect )
 {
-    return ((rect->left == rect->right) || (rect->top == rect->bottom));
+    return ((rect->left >= rect->right) || (rect->top >= rect->bottom));
 }


 /***********************************************************************
 *           IsRectEmpty32    (USER32.347)
+ *
+ * Bug compat: Windows checks for 0 or negative width/height.
 */
 BOOL WINAPI IsRectEmpty( const RECT *rect )
 {
-    return ((rect->left == rect->right) || (rect->top == rect->bottom));
+    return ((rect->left >= rect->right) || (rect->top >= rect->bottom));
 }