Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
8c5718ec
Commit
8c5718ec
authored
Oct 22, 2010
by
Aleksey Bragin
Committed by
Alexandre Julliard
Oct 22, 2010
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
msi: Fix freed memory access and fix freeing of invalid pointer.
parent
8819ae1e
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
5 additions
and
2 deletions
+5
-2
action.c
dlls/msi/action.c
+5
-2
No files found.
dlls/msi/action.c
View file @
8c5718ec
...
...
@@ -2083,7 +2083,7 @@ static UINT ITERATE_CostFinalizeConditions(MSIRECORD *row, LPVOID param)
VS_FIXEDFILEINFO
*
msi_get_disk_file_version
(
LPCWSTR
filename
)
{
static
const
WCHAR
name
[]
=
{
'\\'
,
0
};
VS_FIXEDFILEINFO
*
ret
;
VS_FIXEDFILEINFO
*
ptr
,
*
ret
;
LPVOID
version
;
DWORD
versize
,
handle
;
UINT
sz
;
...
...
@@ -2100,12 +2100,15 @@ VS_FIXEDFILEINFO *msi_get_disk_file_version( LPCWSTR filename )
GetFileVersionInfoW
(
filename
,
0
,
versize
,
version
);
if
(
!
VerQueryValueW
(
version
,
name
,
(
LPVOID
*
)
&
ret
,
&
sz
))
if
(
!
VerQueryValueW
(
version
,
name
,
(
LPVOID
*
)
&
ptr
,
&
sz
))
{
msi_free
(
version
);
return
NULL
;
}
ret
=
msi_alloc
(
sz
);
memcpy
(
ret
,
ptr
,
sz
);
msi_free
(
version
);
return
ret
;
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment