wined3d: Try to make Coverity shut up (CID 863, 905).

Comparing gl_shaders against NULL after potentially dereferencing it a few lines earlier probably confuses Coverity. Checking num_gl_shaders instead should avoid this.

wined3d: Try to make Coverity shut up (CID 863, 905).
8ce2506a · Henri Verbeet · Alexandre Julliard · bdd1206c · 8ce2506a · 8ce2506a
Commit 8ce2506a authored Mar 24, 2009 by Henri Verbeet Committed by Alexandre Julliard Mar 24, 2009
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

pixelshader.c dlls/wined3d/pixelshader.c +2 -1

vertexshader.c dlls/wined3d/vertexshader.c +2 -1

No files found.
--- a/dlls/wined3d/pixelshader.c
+++ b/dlls/wined3d/pixelshader.c
@@ -530,7 +530,8 @@ GLuint find_gl_pshader(IWineD3DPixelShaderImpl *shader, const struct ps_compile_

    TRACE("No matching GL shader found, compiling a new shader\n");
    if(shader->shader_array_size == shader->num_gl_shaders) {
-        if(shader->gl_shaders) {
+        if (shader->num_gl_shaders)
+        {
            new_size = shader->shader_array_size + max(1, shader->shader_array_size / 2);
            new_array = HeapReAlloc(GetProcessHeap(), 0, shader->gl_shaders,
                                    new_size * sizeof(*shader->gl_shaders));

--- a/dlls/wined3d/vertexshader.c
+++ b/dlls/wined3d/vertexshader.c
@@ -465,7 +465,8 @@ GLuint find_gl_vshader(IWineD3DVertexShaderImpl *shader, const struct vs_compile
    TRACE("No matching GL shader found, compiling a new shader\n");

    if(shader->shader_array_size == shader->num_gl_shaders) {
-        if(shader->gl_shaders) {
+        if (shader->num_gl_shaders)
+        {
            new_size = shader->shader_array_size + max(1, shader->shader_array_size / 2);
            new_array = HeapReAlloc(GetProcessHeap(), 0, shader->gl_shaders,
                                    new_size * sizeof(*shader->gl_shaders));