Don't read uninitialized data when a '$' is found.

8e94fbf3 · Adam Gundy · Alexandre Julliard · 60b28eed · 8e94fbf3
Commit 8e94fbf3 authored Mar 30, 2003 by Adam Gundy Committed by Alexandre Julliard Mar 30, 2003
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 1 deletion

profile.c files/profile.c +7 -1

No files found.
--- a/files/profile.c
+++ b/files/profile.c
@@ -120,7 +120,8 @@ static void PROFILE_CopyEntry( LPWSTR buffer, LPCWSTR value, int len,
        return;
    }

-    for (p = value; (*p && (len > 1)); *buffer++ = *p++, len-- )
+    p = value;
+    while (*p && (len > 1))
    {
        if ((*p == '$') && (p[1] == '{'))
        {
@@ -140,6 +141,11 @@ static void PROFILE_CopyEntry( LPWSTR buffer, LPCWSTR value, int len,
            }
            p = p2 + 1;
        }
+        else
+        {
+            *buffer++ = *p++;
+            len--;
+        }
    }
    if (quote && (len > 1)) buffer--;
    *buffer = '\0';