comctl32/listview: Convert item text once when looking for insertion point.

Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

comctl32/listview: Convert item text once when looking for insertion point.
8ef79b02 · Nikolay Sivov · Alexandre Julliard · d3d8d4f3 · 8ef79b02
Commit 8ef79b02 authored May 09, 2017 by Nikolay Sivov Committed by Alexandre Julliard May 09, 2017
Show whitespace changes
Inline Side-by-side

Showing with 7 additions and 1 deletion

listview.c dlls/comctl32/listview.c +7 -1

No files found.
--- a/dlls/comctl32/listview.c
+++ b/dlls/comctl32/listview.c
@@ -7824,18 +7824,24 @@ static INT LISTVIEW_InsertItemT(LISTVIEW_INFO *infoPtr, const LVITEMW *lpLVItem,
        HDPA hItem;
        ITEM_INFO *item_s;
        INT i = 0, cmpv;
+        WCHAR *textW;
+
+        textW = textdupTtoW(lpLVItem->pszText, isW);

        while (i < infoPtr->nItemCount)
        {
            hItem  = DPA_GetPtr( infoPtr->hdpaItems, i);
            item_s = DPA_GetPtr(hItem, 0);

-            cmpv = textcmpWT(item_s->hdr.pszText, lpLVItem->pszText, isW);
+            cmpv = textcmpWT(item_s->hdr.pszText, textW, TRUE);
            if (infoPtr->dwStyle & LVS_SORTDESCENDING) cmpv *= -1;

            if (cmpv >= 0) break;
            i++;
        }
+
+        textfreeT(textW, isW);
+
        nItem = i;
    }
    else