mf/session: Avoid dropping samples delivered from transform in session_request_sample_from_node().

session_request_sample() calls session_request_sample_from_node() and increments sink.requests only if that succeeds. But session_request_sample_from_node() calls session_deliver_sample_to_node() synchronously for MF_TOPOLOGY_TRANSFORM_NODE if there are output samples available. Then, if sink.requests is zero before this session_request_sample() call that sample is silently dropped.

mf/session: Avoid dropping samples delivered from transform in session_request_sample_from_node().
9070f0d5 · Paul Gofman · Alexandre Julliard · 7ac3b0fd · 9070f0d5
Commit 9070f0d5 authored Jan 24, 2023 by Paul Gofman Committed by Alexandre Julliard Feb 11, 2023
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

session.c dlls/mf/session.c +3 -2

No files found.
--- a/dlls/mf/session.c
+++ b/dlls/mf/session.c
@@ -3388,8 +3388,9 @@ static void session_request_sample(struct media_session *session, IMFStreamSink 
        return;
    }

-    if (SUCCEEDED(session_request_sample_from_node(session, upstream_node, upstream_output)))
-        sink_node->u.sink.requests++;
+    sink_node->u.sink.requests++;
+    if (FAILED(session_request_sample_from_node(session, upstream_node, upstream_output)))
+        sink_node->u.sink.requests--;
    IMFTopologyNode_Release(upstream_node);
 }