d3d8: Fix crash in d3d8_vertexbuffer_Release().

Signed-off-by: Paul Gofman <gofmanp@gmail.com> Signed-off-by: Henri Verbeet <hverbeet@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

d3d8: Fix crash in d3d8_vertexbuffer_Release().
90bd6dc3 · Paul Gofman · Alexandre Julliard · a878b0fa · 90bd6dc3
Commit 90bd6dc3 authored Dec 18, 2018 by Paul Gofman Committed by Alexandre Julliard Dec 20, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

buffer.c dlls/d3d8/buffer.c +3 -2

No files found.
--- a/dlls/d3d8/buffer.c
+++ b/dlls/d3d8/buffer.c
@@ -74,12 +74,13 @@ static ULONG WINAPI d3d8_vertexbuffer_Release(IDirect3DVertexBuffer8 *iface)

    if (!refcount)
    {
+        struct wined3d_buffer *draw_buffer = buffer->draw_buffer;
        IDirect3DDevice8 *device = buffer->parent_device;

        wined3d_mutex_lock();
        wined3d_buffer_decref(buffer->wined3d_buffer);
-        if (buffer->draw_buffer)
-            wined3d_buffer_decref(buffer->draw_buffer);
+        if (draw_buffer)
+            wined3d_buffer_decref(draw_buffer);
        wined3d_mutex_unlock();

        /* Release the device last, as it may cause the device to be destroyed. */