gdiplus: Check that GdipAddPathLine2 is passed at least one point.

Signed-off-by: Jeff Smith <whydoubt@gmail.com> Signed-off-by: Vincent Povirk <vincent@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

gdiplus: Check that GdipAddPathLine2 is passed at least one point.
93a5ce24 · Jeff Smith · Alexandre Julliard · efd5f670 · 93a5ce24 · 93a5ce24
Commit 93a5ce24 authored Apr 13, 2020 by Jeff Smith Committed by Alexandre Julliard Apr 14, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 11 additions and 1 deletion

graphicspath.c dlls/gdiplus/graphicspath.c +1 -1

graphicspath.c dlls/gdiplus/tests/graphicspath.c +10 -0

No files found.
--- a/dlls/gdiplus/graphicspath.c
+++ b/dlls/gdiplus/graphicspath.c
@@ -627,7 +627,7 @@ GpStatus WINGDIPAPI GdipAddPathLine2(GpPath *path, GDIPCONST GpPointF *points,

    TRACE("(%p, %p, %d)\n", path, points, count);

-    if(!path || !points)
+    if(!path || !points || count < 1)
        return InvalidParameter;

    if(!lengthen_path(path, count))

--- a/dlls/gdiplus/tests/graphicspath.c
+++ b/dlls/gdiplus/tests/graphicspath.c
@@ -308,6 +308,16 @@ static void test_line2(void)
    }

    GdipCreatePath(FillModeAlternate, &path);
+
+    status = GdipAddPathLine2(NULL, line2_points, 2);
+    expect(InvalidParameter, status);
+    status = GdipAddPathLine2(path, NULL, 2);
+    expect(InvalidParameter, status);
+    status = GdipAddPathLine2(path, line2_points, 0);
+    expect(InvalidParameter, status);
+    status = GdipAddPathLine2(path, line2_points, -1);
+    expect(InvalidParameter, status);
+
    status = GdipAddPathLine2(path, line2_points, 3);
    expect(Ok, status);
    status = GdipAddPathLine2(path, &(line2_points[3]), 3);