Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
93e76ece
Commit
93e76ece
authored
Jul 10, 2008
by
Piotr Caban
Committed by
Alexandre Julliard
Jul 10, 2008
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
msxml3: oldChild in xmlnode_removeChild may be NULL.
parent
088f3eef
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
17 additions
and
2 deletions
+17
-2
node.c
dlls/msxml3/node.c
+5
-2
domdoc.c
dlls/msxml3/tests/domdoc.c
+12
-0
No files found.
dlls/msxml3/node.c
View file @
93e76ece
...
...
@@ -625,7 +625,8 @@ static HRESULT WINAPI xmlnode_removeChild(
TRACE
(
"%p->(%p, %p)
\n
"
,
This
,
childNode
,
oldChild
);
*
oldChild
=
NULL
;
if
(
oldChild
)
*
oldChild
=
NULL
;
if
(
!
childNode
)
return
E_INVALIDARG
;
...
...
@@ -651,7 +652,9 @@ static HRESULT WINAPI xmlnode_removeChild(
IXMLDOMNode_Release
(
child
);
IXMLDOMNode_AddRef
(
childNode
);
*
oldChild
=
childNode
;
if
(
oldChild
)
*
oldChild
=
childNode
;
return
S_OK
;
}
...
...
dlls/msxml3/tests/domdoc.c
View file @
93e76ece
...
...
@@ -1769,6 +1769,18 @@ static void test_removeChild(void)
IXMLDOMNode_Release
(
node2
);
IXMLDOMNode_Release
(
node4
);
r
=
IXMLDOMNodeList_get_item
(
node_list
,
0
,
&
node4
);
ok
(
r
==
S_OK
,
"ret %08x
\n
"
,
r
);
r
=
IXMLDOMElement_removeChild
(
element
,
node4
,
NULL
);
ok
(
r
==
S_OK
,
"ret %08x
\n
"
,
r
);
r
=
IXMLDOMNode_get_parentNode
(
node4
,
&
node3
);
ok
(
r
==
S_FALSE
,
"ret %08x
\n
"
,
r
);
ok
(
node3
==
NULL
,
"%p
\n
"
,
node3
);
IXMLDOMNode_Release
(
node4
);
IXMLDOMNodeList_Release
(
node_list2
);
IXMLDOMNode_Release
(
node
);
IXMLDOMNodeList_Release
(
node_list
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment