hidclass.sys: Drop reports when length doesn't match their declaration.

Based on a patch from Ivo Ivanov <logos128@gmail.com>. Instead of using the descriptor input report length, which is the maximum length of all input reports. Tests show that the reports should be dropped, in non-polled mode, when their length is invalid, but we were dropping too many of them. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51828Signed-off-by: Rémi Bernon <rbernon@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

hidclass.sys: Drop reports when length doesn't match their declaration.
9411ecf6 · Rémi Bernon · Alexandre Julliard · 3c743180 · 9411ecf6
Commit 9411ecf6 authored Oct 04, 2021 by Rémi Bernon Committed by Alexandre Julliard Oct 04, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

device.c dlls/hidclass.sys/device.c +2 -1

No files found.
--- a/dlls/hidclass.sys/device.c
+++ b/dlls/hidclass.sys/device.c
@@ -349,7 +349,8 @@ static DWORD CALLBACK hid_device_thread(void *args)
            packet->reportBuffer = buffer;
            packet->reportBufferLen = io.Information;

-            if (polled || io.Information == desc->InputLength)
+            report = find_report_with_type_and_id( ext, HidP_Input, buffer[0], FALSE );
+            if (polled || (report && report->InputLength == io.Information))
                hid_device_queue_input( device, packet );
        }