Skip to content

W
wine-winehq
Commit 94512ecc authored by Jinoh Kang's avatar Jinoh Kang Committed by Alexandre Julliard
Browse files
Options

concrt140: Use atomic write for releasing threadsafe_queue spin lock.

This fixes data race in ARM/ARM64 platforms, and prevents potential memory access reordering by the compiler.
parent d1e23696
Hide whitespace changes
Inline Side-by-side
Showing with 2 additions and 2 deletions
dlls/concrt140/details.c
View file @ 94512ecc
...@@ -225,7 +225,7 @@ static void threadsafe_queue_push(threadsafe_queue *queue, size_t id, ...@@ -225,7 +225,7 @@ static void threadsafe_queue_push(threadsafe_queue *queue, size_t id,
queue->tail = p; queue->tail = p;
if(!queue->head) if(!queue->head)
queue->head = p; queue->head = p;
queue->lock = 0; WriteRelease(&queue->lock, 0);
} }
else else
{ {
...@@ -275,7 +275,7 @@ static BOOL threadsafe_queue_pop(threadsafe_queue *queue, size_t id, ...@@ -275,7 +275,7 @@ static BOOL threadsafe_queue_pop(threadsafe_queue *queue, size_t id,
queue->head = p->_Next; queue->head = p->_Next;
if(!queue->head) if(!queue->head)
queue->tail = NULL; queue->tail = NULL;
queue->lock = 0; WriteRelease(&queue->lock, 0);
/* TODO: Add exception handling */ /* TODO: Add exception handling */
call__Concurrent_queue_base_v4__Deallocate_page(parent, p); call__Concurrent_queue_base_v4__Deallocate_page(parent, p);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment