joy.cpl: Better handle effect creation errors.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51873Signed-off-by: Rémi Bernon <rbernon@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

joy.cpl: Better handle effect creation errors.
960bb369 · Rémi Bernon · Alexandre Julliard · f1017125 · 960bb369
Commit 960bb369 authored Oct 14, 2021 by Rémi Bernon Committed by Alexandre Julliard Oct 14, 2021
Show whitespace changes
Inline Side-by-side

Showing with 5 additions and 0 deletions

main.c dlls/joy.cpl/main.c +5 -0

No files found.
--- a/dlls/joy.cpl/main.c
+++ b/dlls/joy.cpl/main.c
@@ -867,6 +867,11 @@ static BOOL CALLBACK ff_effects_callback(const DIEFFECTINFOW *pdei, void *pvRef)
    hr = IDirectInputDevice2_CreateEffect(
        joystick->device, &pdei->guid, &dieffect, &joystick->effects[joystick->cur_effect].effect, NULL);
+    if (FAILED(hr))
+    {
+        FIXME("Failed to create effect with type %s, hr %#x\n", debugstr_guid(&pdei->guid), hr);
+        return DIENUM_CONTINUE;
+    }
    joystick->effects[joystick->cur_effect].params = dieffect;
    joystick->effects[joystick->cur_effect].info = *pdei;