gameux: Avoid double free (coverity).

97dbccf5 · André Hentschel · Alexandre Julliard · 07fd75ba · 97dbccf5
Commit 97dbccf5 authored Oct 24, 2012 by André Hentschel Committed by Alexandre Julliard Oct 25, 2012
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

gameexplorer.c dlls/gameux/gameexplorer.c +3 -1

No files found.
--- a/dlls/gameux/gameexplorer.c
+++ b/dlls/gameux/gameexplorer.c
@@ -783,13 +783,15 @@ HRESULT GAMEUX_FindGameInstanceId(
                                             sConfigGDFBinaryPath, &lpValue);

                if(SUCCEEDED(hr))
+                {
                    if(lstrcmpW(lpValue, sGDFBinaryPath)==0)
                    {
                        /* key found, let's copy instance id and exit */
                        hr = (GUIDFromStringW(lpName, pInstanceId) ? S_OK : E_FAIL);
                        found = TRUE;
                    }
-                HeapFree(GetProcessHeap(), 0, lpValue);
+                    HeapFree(GetProcessHeap(), 0, lpValue);
+                }
            }
        }