dinput: Unacquire device when last public reference is released.

Avoid crashing in dinput_device_destroy, calling Unacquire while device resources may be already freed up. Signed-off-by: Ivo Ivanov <logos128@gmail.com> Signed-off-by: Rémi Bernon <rbernon@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

dinput: Unacquire device when last public reference is released.
99fc12f9 · Ivo Ivanov · Alexandre Julliard · dbb735ef · 99fc12f9
Commit 99fc12f9 authored Nov 12, 2021 by Ivo Ivanov Committed by Alexandre Julliard Nov 12, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 2 deletions

device.c dlls/dinput/device.c +1 -2

No files found.
--- a/dlls/dinput/device.c
+++ b/dlls/dinput/device.c
@@ -740,8 +740,6 @@ void dinput_device_destroy( IDirectInputDevice8W *iface )

    TRACE( "iface %p.\n", iface );

-    IDirectInputDevice_Unacquire(iface);
-
    free( This->data_queue );

    /* Free data format */
@@ -768,6 +766,7 @@ static ULONG WINAPI dinput_device_Release( IDirectInputDevice8W *iface )

    if (!ref)
    {
+        IDirectInputDevice_Unacquire( iface );
        if (impl->vtbl->release) impl->vtbl->release( iface );
        else dinput_device_destroy( iface );
    }