Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
9e50cc54
Commit
9e50cc54
authored
Sep 13, 2013
by
Dmitry Timoshkov
Committed by
Alexandre Julliard
Sep 13, 2013
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
ntdll: NtWriteFile should fail for overlapped IO on files if offset is negative.
parent
84d9b250
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
1 addition
and
15 deletions
+1
-15
file.c
dlls/ntdll/file.c
+1
-1
file.c
dlls/ntdll/tests/file.c
+0
-14
No files found.
dlls/ntdll/file.c
View file @
9e50cc54
...
...
@@ -961,7 +961,7 @@ NTSTATUS WINAPI NtWriteFile(HANDLE hFile, HANDLE hEvent,
if
(
type
==
FD_TYPE_FILE
)
{
if
(
!
(
options
&
(
FILE_SYNCHRONOUS_IO_ALERT
|
FILE_SYNCHRONOUS_IO_NONALERT
))
&&
!
offset
)
if
(
!
(
options
&
(
FILE_SYNCHRONOUS_IO_ALERT
|
FILE_SYNCHRONOUS_IO_NONALERT
))
&&
(
!
offset
||
offset
->
QuadPart
<
0
)
)
{
status
=
STATUS_INVALID_PARAMETER
;
goto
done
;
...
...
dlls/ntdll/tests/file.c
View file @
9e50cc54
...
...
@@ -2198,9 +2198,6 @@ todo_wine
for
(
i
=
-
20
;
i
<
-
1
;
i
++
)
{
/* FIXME: Remove once Wine is fixed */
if
(
i
==
-
2
)
continue
;
iob
.
Status
=
-
1
;
iob
.
Information
=
-
1
;
offset
.
QuadPart
=
(
LONGLONG
)
i
;
...
...
@@ -2212,17 +2209,6 @@ todo_wine
iob
.
Status
=
-
1
;
iob
.
Information
=
-
1
;
offset
.
QuadPart
=
(
LONGLONG
)
-
2
/* FILE_USE_FILE_POINTER_POSITION */
;
status
=
pNtWriteFile
(
hfile
,
0
,
NULL
,
NULL
,
&
iob
,
contents
,
sizeof
(
contents
),
&
offset
,
NULL
);
todo_wine
ok
(
status
==
STATUS_INVALID_PARAMETER
,
"expected STATUS_INVALID_PARAMETER, got %#x
\n
"
,
status
);
todo_wine
ok
(
iob
.
Status
==
-
1
,
"expected -1, got %#x
\n
"
,
iob
.
Status
);
todo_wine
ok
(
iob
.
Information
==
-
1
,
"expected -1, got %ld
\n
"
,
iob
.
Information
);
iob
.
Status
=
-
1
;
iob
.
Information
=
-
1
;
offset
.
QuadPart
=
0
;
status
=
pNtWriteFile
(
hfile
,
0
,
NULL
,
NULL
,
&
iob
,
contents
,
sizeof
(
contents
),
&
offset
,
NULL
);
todo_wine
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment