mf: Make session_get_node_object() more robust.

It's possible that a state object pointer not in the topology node collection gets passed to session_get_node_object(). Instead of returning the last node when the object is not found, we should return a NULL so that the state of the last node is not changed by mistake. Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>

mf: Make session_get_node_object() more robust.
a00b30bf · Zhiyi Zhang · Alexandre Julliard · 06482e32 · a00b30bf
Commit a00b30bf authored Aug 07, 2023 by Zhiyi Zhang Committed by Alexandre Julliard Feb 06, 2024
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

session.c dlls/mf/session.c +2 -2

No files found.
--- a/dlls/mf/session.c
+++ b/dlls/mf/session.c
@@ -2851,10 +2851,10 @@ static struct topo_node *session_get_node_object(struct media_session *session, 
    LIST_FOR_EACH_ENTRY(node, &session->presentation.nodes, struct topo_node, entry)
    {
        if (node->type == node_type && object == node->object.object)
-            break;
+            return node;
    }

-    return node;
+    return NULL;
 }

 static BOOL session_set_node_object_state(struct media_session *session, IUnknown *object,