Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
a0a800ab
Commit
a0a800ab
authored
Sep 13, 2021
by
Hans Leidekker
Committed by
Alexandre Julliard
Sep 13, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
msi: Don't leak the file handle on error in cabinet_close_file_info().
Signed-off-by:
Hans Leidekker
<
hans@codeweavers.com
>
Signed-off-by:
Alexandre Julliard
<
julliard@winehq.org
>
parent
c8e28023
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
10 additions
and
3 deletions
+10
-3
media.c
dlls/msi/media.c
+10
-3
No files found.
dlls/msi/media.c
View file @
a0a800ab
...
@@ -507,16 +507,23 @@ static INT_PTR cabinet_close_file_info(FDINOTIFICATIONTYPE fdint,
...
@@ -507,16 +507,23 @@ static INT_PTR cabinet_close_file_info(FDINOTIFICATIONTYPE fdint,
data
->
mi
->
is_continuous
=
FALSE
;
data
->
mi
->
is_continuous
=
FALSE
;
if
(
!
DosDateTimeToFileTime
(
pfdin
->
date
,
pfdin
->
time
,
&
ft
))
if
(
!
DosDateTimeToFileTime
(
pfdin
->
date
,
pfdin
->
time
,
&
ft
))
{
CloseHandle
(
handle
);
return
-
1
;
return
-
1
;
}
if
(
!
LocalFileTimeToFileTime
(
&
ft
,
&
ftLocal
))
if
(
!
LocalFileTimeToFileTime
(
&
ft
,
&
ftLocal
))
{
CloseHandle
(
handle
);
return
-
1
;
return
-
1
;
}
if
(
!
SetFileTime
(
handle
,
&
ftLocal
,
0
,
&
ftLocal
))
if
(
!
SetFileTime
(
handle
,
&
ftLocal
,
0
,
&
ftLocal
))
{
CloseHandle
(
handle
);
return
-
1
;
return
-
1
;
}
CloseHandle
(
handle
);
CloseHandle
(
handle
);
data
->
cb
(
data
->
package
,
data
->
curfile
,
MSICABEXTRACT_FILEEXTRACTED
,
NULL
,
NULL
,
data
->
user
);
data
->
cb
(
data
->
package
,
data
->
curfile
,
MSICABEXTRACT_FILEEXTRACTED
,
NULL
,
NULL
,
data
->
user
);
msi_free
(
data
->
curfile
);
msi_free
(
data
->
curfile
);
data
->
curfile
=
NULL
;
data
->
curfile
=
NULL
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment