wbemprox: Fix multiple leaks in parse_path (Coverity).

Signed-off-by: Sven Baars <sven.wine@gmail.com> Signed-off-by: Hans Leidekker <hans@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wbemprox: Fix multiple leaks in parse_path (Coverity).
a3b6054a · Sven Baars · Alexandre Julliard · 11470a77 · a3b6054a
Commit a3b6054a authored Oct 04, 2019 by Sven Baars Committed by Alexandre Julliard Oct 07, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 21 additions and 3 deletions

services.c dlls/wbemprox/services.c +21 -3

No files found.
--- a/dlls/wbemprox/services.c
+++ b/dlls/wbemprox/services.c
@@ -335,24 +335,42 @@ HRESULT parse_path( const WCHAR *str, struct path **ret )
        DWORD server_len = ARRAY_SIZE(server);

        p++;
-        if (*p != '\\') return WBEM_E_INVALID_OBJECT_PATH;
+        if (*p != '\\')
+        {
+            heap_free( path );
+            return WBEM_E_INVALID_OBJECT_PATH;
+        }
        p++;

        q = p;
        while (*p && *p != '\\') p++;
-        if (!*p) return WBEM_E_INVALID_OBJECT_PATH;
+        if (!*p)
+        {
+            heap_free( path );
+            return WBEM_E_INVALID_OBJECT_PATH;
+        }

        len = p - q;
        if (!GetComputerNameW( server, &server_len ) || server_len != len || wcsnicmp( q, server, server_len ))
+        {
+            heap_free( path );
            return WBEM_E_NOT_SUPPORTED;
+        }

        q = ++p;
        while (*p && *p != ':') p++;
-        if (!*p) return WBEM_E_INVALID_OBJECT_PATH;
+        if (!*p)
+        {
+            heap_free( path );
+            return WBEM_E_INVALID_OBJECT_PATH;
+        }

        len = p - q;
        if (len != ARRAY_SIZE(cimv2W) - 1 || wcsnicmp( q, cimv2W, ARRAY_SIZE(cimv2W) - 1 ))
+        {
+            heap_free( path );
            return WBEM_E_INVALID_NAMESPACE;
+        }
        p++;
    }