msi: Don't fail the BindImage action if the BindImage table is absent.

This fixes a regression introduced with 15f85201 and observable with several installers, including dotnet472. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46885Signed-off-by: Zebediah Figura <z.figura12@gmail.com> Signed-off-by: Hans Leidekker <hans@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

msi: Don't fail the BindImage action if the BindImage table is absent.
a3dfd2f2 · Zebediah Figura · Alexandre Julliard · a5fe3d65 · a3dfd2f2 · a3dfd2f2
Commit a3dfd2f2 authored Mar 24, 2019 by Zebediah Figura Committed by Alexandre Julliard Mar 25, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

action.c dlls/msi/action.c +2 -2

install.c dlls/msi/tests/install.c +1 -0

No files found.
--- a/dlls/msi/action.c
+++ b/dlls/msi/action.c
@@ -7809,10 +7809,10 @@ static UINT ACTION_BindImage( MSIPACKAGE *package )
    r = MSI_DatabaseOpenViewW( package->db, query, &view );
    if (r == ERROR_SUCCESS)
    {
-        r = MSI_IterateRecords( view, NULL, ITERATE_BindImage, package );
+        MSI_IterateRecords( view, NULL, ITERATE_BindImage, package );
        msiobj_release( &view->hdr );
    }
-    return r;
+    return ERROR_SUCCESS;
 }

 static UINT msi_unimplemented_action_stub( MSIPACKAGE *package, LPCSTR action, LPCWSTR table )

--- a/dlls/msi/tests/install.c
+++ b/dlls/msi/tests/install.c
@@ -135,6 +135,7 @@ static const CHAR install_exec_seq_dat[] = "Action\tCondition\tSequence\n"
                                           "ResolveSource\t\t950\n"
                                           "MoveFiles\t\t1700\n"
                                           "InstallFiles\t\t4000\n"
+                                           "BindImage\t\t4100\n"
                                           "DuplicateFiles\t\t4500\n"
                                           "WriteEnvironmentStrings\t\t4550\n"
                                           "CreateShortcuts\t\t4600\n"