mshtml: Handle non-HTML element in IHTMLSelectElement:add implementation.

Signed-off-by: Jacek Caban <jacek@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

mshtml: Handle non-HTML element in IHTMLSelectElement:add implementation.
a4ad2cf8 · Jacek Caban · Alexandre Julliard · fba6da79 · a4ad2cf8
Commit a4ad2cf8 authored Feb 12, 2018 by Jacek Caban Committed by Alexandre Julliard Feb 13, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 1 deletion

htmlselect.c dlls/mshtml/htmlselect.c +6 -1

No files found.
--- a/dlls/mshtml/htmlselect.c
+++ b/dlls/mshtml/htmlselect.c
@@ -425,6 +425,11 @@ static HRESULT WINAPI HTMLSelectElement_add(IHTMLSelectElement *iface, IHTMLElem
        return E_INVALIDARG;
    }

+    if(!element_obj->html_element) {
+        FIXME("Not HTML element\n");
+        return E_NOTIMPL;
+    }
+
    nsvariant = create_nsvariant();
    if(!nsvariant)
        return E_FAIL;
@@ -444,7 +449,7 @@ static HRESULT WINAPI HTMLSelectElement_add(IHTMLSelectElement *iface, IHTMLElem
    }

    if(NS_SUCCEEDED(nsres))
-        nsres = nsIDOMHTMLSelectElement_Add(This->nsselect, element_obj->nselem, (nsIVariant*)nsvariant);
+        nsres = nsIDOMHTMLSelectElement_Add(This->nsselect, element_obj->html_element, (nsIVariant*)nsvariant);
    nsIWritableVariant_Release(nsvariant);
    if(NS_FAILED(nsres)) {
        ERR("Add failed: %08x\n", nsres);