Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
a6b714d0
Commit
a6b714d0
authored
Jun 26, 2011
by
Marcus Meissner
Committed by
Alexandre Julliard
Jun 27, 2011
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
ddrawex: Remove superflous NULL checks, add error skips (Coverity).
parent
e4d63f77
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
13 additions
and
8 deletions
+13
-8
surface.c
dlls/ddrawex/tests/surface.c
+13
-8
No files found.
dlls/ddrawex/tests/surface.c
View file @
a6b714d0
...
...
@@ -422,8 +422,17 @@ START_TEST(surface)
hr
=
pDllGetClassObject
(
&
CLSID_DirectDrawFactory
,
&
IID_IClassFactory
,
(
void
**
)
&
classfactory
);
ok
(
hr
==
S_OK
,
"Failed to create a IClassFactory
\n
"
);
if
(
!
SUCCEEDED
(
hr
))
{
skip
(
"Failed to get DirectDrawFactory
\n
"
);
return
;
}
hr
=
IClassFactory_CreateInstance
(
classfactory
,
NULL
,
&
IID_IDirectDrawFactory
,
(
void
**
)
&
factory
);
ok
(
hr
==
S_OK
,
"Failed to create a IDirectDrawFactory
\n
"
);
if
(
!
SUCCEEDED
(
hr
))
{
IClassFactory_Release
(
classfactory
);
skip
(
"Failed to get a DirectDrawFactory
\n
"
);
return
;
}
GetDCTest
();
CapsTest
();
...
...
@@ -431,12 +440,8 @@ START_TEST(surface)
test_surface_from_dc3
();
test_surface_from_dc4
();
if
(
factory
)
{
ref
=
IDirectDrawFactory_Release
(
factory
);
ok
(
ref
==
0
,
"IDirectDrawFactory not cleanly released
\n
"
);
}
if
(
classfactory
)
{
ref
=
IClassFactory_Release
(
classfactory
);
todo_wine
ok
(
ref
==
1
,
"IClassFactory refcount wrong, ref = %u
\n
"
,
ref
);
}
ref
=
IDirectDrawFactory_Release
(
factory
);
ok
(
ref
==
0
,
"IDirectDrawFactory not cleanly released
\n
"
);
ref
=
IClassFactory_Release
(
classfactory
);
todo_wine
ok
(
ref
==
1
,
"IClassFactory refcount wrong, ref = %u
\n
"
,
ref
);
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment