mshtml: Do not release the principal returned by GetPrincipal.

Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>

mshtml: Do not release the principal returned by GetPrincipal.
a80a3be4 · Gabriel Ivăncescu · Alexandre Julliard · 60adbec7 · a80a3be4
Commit a80a3be4 authored Apr 25, 2023 by Gabriel Ivăncescu Committed by Alexandre Julliard Apr 25, 2023
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

nsembed.c dlls/mshtml/nsembed.c +1 -1

No files found.
--- a/dlls/mshtml/nsembed.c
+++ b/dlls/mshtml/nsembed.c
@@ -2440,6 +2440,7 @@ nsIXMLHttpRequest *create_nsxhr(nsIDOMWindow *nswindow)
    nsres = nsIGlobalObject_QueryInterface(nsglo, &IID_nsIScriptObjectPrincipal, (void**)&sop);
    assert(nsres == NS_OK);

+    /* The returned principal is *not* AddRef'd */
    nspri = nsIScriptObjectPrincipal_GetPrincipal(sop);
    nsIScriptObjectPrincipal_Release(sop);

@@ -2451,7 +2452,6 @@ nsIXMLHttpRequest *create_nsxhr(nsIDOMWindow *nswindow)
        if(NS_FAILED(nsres))
            nsIXMLHttpRequest_Release(nsxhr);
    }
-    nsISupports_Release(nspri);
    nsIGlobalObject_Release(nsglo);
    if(NS_FAILED(nsres)) {
        ERR("nsIXMLHttpRequest_Init failed: %08lx\n", nsres);