comctl32/listview: Don't repaint when handling WM_STYLECHANGED.

Some applications subclass listview and change style multiple times when painting. Invalidating control when handling WM_STYLECHANGED causes infinite WM_PAINT messages in this case and end up stalling the message queue.

comctl32/listview: Don't repaint when handling WM_STYLECHANGED.
a8396d8b · Zhiyi Zhang · Alexandre Julliard · 44cfa3ec · a8396d8b · a8396d8b
Commit a8396d8b authored Oct 17, 2022 by Zhiyi Zhang Committed by Alexandre Julliard Oct 18, 2022
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 4 deletions

listview.c dlls/comctl32/listview.c +0 -3

misc.c dlls/comctl32/tests/misc.c +1 -1

No files found.
--- a/dlls/comctl32/listview.c
+++ b/dlls/comctl32/listview.c
@@ -11298,9 +11298,6 @@ static INT LISTVIEW_StyleChanged(LISTVIEW_INFO *infoPtr, WPARAM wStyleType,
    /* add scrollbars if needed */
    LISTVIEW_UpdateScroll(infoPtr);

-    /* invalidate client area + erase background */
-    LISTVIEW_InvalidateList(infoPtr);
-
    return 0;
 }


--- a/dlls/comctl32/tests/misc.c
+++ b/dlls/comctl32/tests/misc.c
@@ -1096,7 +1096,7 @@ static void test_WM_STYLECHANGED(void)
        {HOTKEY_CLASSA, wm_stylechanged_seq},
        {WC_IPADDRESSA, wm_stylechanged_seq},
        {WC_LISTBOXA, wm_stylechanged_repaint_seq, TRUE},
-        {WC_LISTVIEWA, wm_stylechanged_seq, TRUE},
+        {WC_LISTVIEWA, wm_stylechanged_seq},
        {MONTHCAL_CLASSA, wm_stylechanged_repaint_seq, TRUE},
        {WC_NATIVEFONTCTLA, wm_stylechanged_seq},
        {WC_PAGESCROLLERA, wm_stylechanged_pager_seq, TRUE},