ws2_32: Set WSAEFAULT if the bind address is null.

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com> Signed-off-by: Zebediah Figura <zfigura@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

ws2_32: Set WSAEFAULT if the bind address is null.
a990e25b · Alex Henrie · Alexandre Julliard · 63110f98 · a990e25b · a990e25b
Commit a990e25b authored Oct 17, 2021 by Alex Henrie Committed by Alexandre Julliard Oct 18, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 13 additions and 2 deletions

socket.c dlls/ws2_32/socket.c +1 -1

sock.c dlls/ws2_32/tests/sock.c +12 -1

No files found.
--- a/dlls/ws2_32/socket.c
+++ b/dlls/ws2_32/socket.c
@@ -1068,7 +1068,7 @@ int WINAPI bind( SOCKET s, const struct sockaddr *addr, int len )

    if (!addr)
    {
-        SetLastError( WSAEAFNOSUPPORT );
+        SetLastError( WSAEFAULT );
        return -1;
    }


--- a/dlls/ws2_32/tests/sock.c
+++ b/dlls/ws2_32/tests/sock.c
@@ -10794,7 +10794,18 @@ static void test_bind(void)
    WSASetLastError(0xdeadbeef);
    ret = bind(s, NULL, 0);
    ok(ret == -1, "expected failure\n");
-    todo_wine ok(WSAGetLastError() == WSAEFAULT, "got error %u\n", WSAGetLastError());
+    ok(WSAGetLastError() == WSAEFAULT, "got error %u\n", WSAGetLastError());
+
+    WSASetLastError(0xdeadbeef);
+    ret = bind(s, NULL, sizeof(addr));
+    ok(ret == -1, "expected failure\n");
+    ok(WSAGetLastError() == WSAEFAULT, "got error %u\n", WSAGetLastError());
+
+    addr.sa_family = AF_INET;
+    WSASetLastError(0xdeadbeef);
+    ret = bind(s, &addr, 0);
+    ok(ret == -1, "expected failure\n");
+    ok(WSAGetLastError() == WSAEFAULT, "got error %u\n", WSAGetLastError());

    addr.sa_family = 0xdead;
    WSASetLastError(0xdeadbeef);