Skip to content

W
wine-winehq
Commit ac524986 authored by Andrew Talbot's avatar Andrew Talbot Committed by Alexandre Julliard
Browse files
Options

winhelp: Fix a memory leak.

parent 4d2e148f
Hide whitespace changes
Inline Side-by-side
Showing with 3 additions and 4 deletions
programs/winhelp/hlpfile.c
View file @ ac524986
...@@ -860,7 +860,7 @@ static BOOL HLPFILE_AddParagraph(HLPFILE *hlpfile, BYTE *buf, BYTE *end, unsigne ...@@ -860,7 +860,7 @@ static BOOL HLPFILE_AddParagraph(HLPFILE *hlpfile, BYTE *buf, BYTE *end, unsigne
HLPFILE_PARAGRAPH *paragraph, **paragraphptr; HLPFILE_PARAGRAPH *paragraph, **paragraphptr;
UINT textsize; UINT textsize;
BYTE *format, *format_end; BYTE *format, *format_end;
char *text, *text_end; char *text, *text_base, *text_end;
long size; long size;
unsigned short bits; unsigned short bits;
unsigned nc, ncol = 1; unsigned nc, ncol = 1;
...@@ -874,7 +874,7 @@ static BOOL HLPFILE_AddParagraph(HLPFILE *hlpfile, BYTE *buf, BYTE *end, unsigne ...@@ -874,7 +874,7 @@ static BOOL HLPFILE_AddParagraph(HLPFILE *hlpfile, BYTE *buf, BYTE *end, unsigne
if (buf + 0x19 > end) {WINE_WARN("header too small\n"); return FALSE;}; if (buf + 0x19 > end) {WINE_WARN("header too small\n"); return FALSE;};
size = GET_UINT(buf, 0x4); size = GET_UINT(buf, 0x4);
text = HeapAlloc(GetProcessHeap(), 0, size); text = text_base = HeapAlloc(GetProcessHeap(), 0, size);
if (!text) return FALSE; if (!text) return FALSE;
if (hlpfile->hasPhrases) if (hlpfile->hasPhrases)
{ {
...@@ -1164,8 +1164,7 @@ static BOOL HLPFILE_AddParagraph(HLPFILE *hlpfile, BYTE *buf, BYTE *end, unsigne ...@@ -1164,8 +1164,7 @@ static BOOL HLPFILE_AddParagraph(HLPFILE *hlpfile, BYTE *buf, BYTE *end, unsigne
} }
} }
} }
if (text_end != (char*)buf + GET_UINT(buf, 0x10) + size) HeapFree(GetProcessHeap(), 0, text_base);
HeapFree(GetProcessHeap(), 0, text_end - size);
return TRUE; return TRUE;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment