wmphoto: Fix memory leak on error path in wmp_decoder_create (Coverity).

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com> Signed-off-by: Esme Povirk <esme@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

wmphoto: Fix memory leak on error path in wmp_decoder_create (Coverity).
adc34921 · Alex Henrie · Alexandre Julliard · e16ccaf0 · adc34921
Commit adc34921 authored Dec 28, 2021 by Alex Henrie Committed by Alexandre Julliard Jan 03, 2022
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 0 deletions

jxrlib.c dlls/wmphoto/jxrlib.c +3 -0

No files found.
--- a/dlls/wmphoto/jxrlib.c
+++ b/dlls/wmphoto/jxrlib.c
@@ -358,7 +358,10 @@ HRESULT CDECL wmp_decoder_create(struct decoder_info *info, struct decoder **res
    if (PKImageDecode_Create_WMP(&decoder)) return E_FAIL;
    This = RtlAllocateHeap(GetProcessHeap(), 0, sizeof(*This));
    if (!This)
+    {
+        decoder->Release(&decoder);
        return E_OUTOFMEMORY;
+    }

    This->decoder_iface.vtable = &wmp_decoder_vtable;
    This->WMPStream_iface.Close = &wmp_stream_Close;