Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
b145f42b
Commit
b145f42b
authored
Sep 16, 2013
by
Dmitry Timoshkov
Committed by
Alexandre Julliard
Sep 16, 2013
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
shlwapi: Write file access also assumes read access.
parent
75fc26f6
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
1 addition
and
19 deletions
+1
-19
istream.c
dlls/shlwapi/istream.c
+1
-3
istream.c
dlls/shlwapi/tests/istream.c
+0
-16
No files found.
dlls/shlwapi/istream.c
View file @
b145f42b
...
...
@@ -420,12 +420,10 @@ HRESULT WINAPI SHCreateStreamOnFileEx(LPCWSTR lpszPath, DWORD dwMode,
/* Access */
switch
(
STGM_ACCESS_MODE
(
dwMode
))
{
case
STGM_WRITE
:
case
STGM_READWRITE
:
dwAccess
=
GENERIC_READ
|
GENERIC_WRITE
;
break
;
case
STGM_WRITE
:
dwAccess
=
GENERIC_WRITE
;
break
;
case
STGM_READ
:
dwAccess
=
GENERIC_READ
;
break
;
...
...
dlls/shlwapi/tests/istream.c
View file @
b145f42b
...
...
@@ -222,27 +222,11 @@ static void test_stream_read_write(IStream *stream, DWORD mode)
ret
=
stream
->
lpVtbl
->
Read
(
stream
,
buf
,
2
,
&
count
);
if
(
written
!=
0
)
{
/* FIXME: Remove once Wine is fixed */
if
(
mode
==
STGM_WRITE
)
todo_wine
ok
(
ret
==
S_OK
,
"IStream_Read error %#x (access %#x, written %u)
\n
"
,
ret
,
mode
,
written
);
else
ok
(
ret
==
S_OK
,
"IStream_Read error %#x (access %#x, written %u)
\n
"
,
ret
,
mode
,
written
);
if
(
mode
==
STGM_WRITE
||
mode
==
STGM_READWRITE
)
{
/* FIXME: Remove once Wine is fixed */
if
(
mode
==
STGM_WRITE
)
{
todo_wine
ok
(
count
==
2
,
"expected 2, got %u
\n
"
,
count
);
todo_wine
ok
(
buf
[
0
]
==
0x5e
&&
buf
[
1
]
==
0xa7
,
"expected 5ea7, got %02x%02x
\n
"
,
buf
[
0
],
buf
[
1
]);
}
else
{
ok
(
count
==
2
,
"expected 2, got %u
\n
"
,
count
);
ok
(
buf
[
0
]
==
0x5e
&&
buf
[
1
]
==
0xa7
,
"expected 5ea7, got %02x%02x
\n
"
,
buf
[
0
],
buf
[
1
]);
}
}
else
ok
(
count
==
0
,
"expected 0, got %u
\n
"
,
count
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment