Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
b4005c15
Commit
b4005c15
authored
Sep 13, 2006
by
Mike McCormack
Committed by
Alexandre Julliard
Sep 13, 2006
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
msi: Fix database creation.
parent
4fa08a63
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
3 deletions
+8
-3
database.c
dlls/msi/database.c
+1
-1
db.c
dlls/msi/tests/db.c
+7
-2
No files found.
dlls/msi/database.c
View file @
b4005c15
...
@@ -107,7 +107,7 @@ UINT MSI_OpenDatabaseW(LPCWSTR szDBPath, LPCWSTR szPersist, MSIDATABASE **pdb)
...
@@ -107,7 +107,7 @@ UINT MSI_OpenDatabaseW(LPCWSTR szDBPath, LPCWSTR szPersist, MSIDATABASE **pdb)
/* FIXME: MSIDBOPEN_CREATE should case STGM_TRANSACTED flag to be
/* FIXME: MSIDBOPEN_CREATE should case STGM_TRANSACTED flag to be
* used here: */
* used here: */
r
=
StgCreateDocfile
(
szDBPath
,
r
=
StgCreateDocfile
(
szDBPath
,
STGM_DIRECT
|
STGM_READWRITE
|
STGM_SHARE_EXCLUSIVE
,
0
,
&
stg
);
STGM_
CREATE
|
STGM_
DIRECT
|
STGM_READWRITE
|
STGM_SHARE_EXCLUSIVE
,
0
,
&
stg
);
if
(
r
==
ERROR_SUCCESS
)
if
(
r
==
ERROR_SUCCESS
)
{
{
IStorage_SetClass
(
stg
,
&
CLSID_MsiDatabase
);
IStorage_SetClass
(
stg
,
&
CLSID_MsiDatabase
);
...
...
dlls/msi/tests/db.c
View file @
b4005c15
...
@@ -109,23 +109,28 @@ static void test_msidatabase(void)
...
@@ -109,23 +109,28 @@ static void test_msidatabase(void)
ok
(
res
==
ERROR_SUCCESS
,
"Failed to close database
\n
"
);
ok
(
res
==
ERROR_SUCCESS
,
"Failed to close database
\n
"
);
ok
(
INVALID_FILE_ATTRIBUTES
!=
GetFileAttributes
(
msifile
),
"database should exist
\n
"
);
ok
(
INVALID_FILE_ATTRIBUTES
!=
GetFileAttributes
(
msifile
),
"database should exist
\n
"
);
todo_wine
{
/* MSIDBOPEN_CREATE deletes the database if MsiCommitDatabase isn't called */
/* MSIDBOPEN_CREATE deletes the database if MsiCommitDatabase isn't called */
res
=
MsiOpenDatabase
(
msifile
,
MSIDBOPEN_CREATE
,
&
hdb
);
res
=
MsiOpenDatabase
(
msifile
,
MSIDBOPEN_CREATE
,
&
hdb
);
ok
(
res
==
ERROR_SUCCESS
,
"Failed to open database
\n
"
);
ok
(
res
==
ERROR_SUCCESS
,
"Failed to open database
\n
"
);
ok
(
INVALID_FILE_ATTRIBUTES
!=
GetFileAttributes
(
msifile
),
"database should exist
\n
"
);
res
=
MsiCloseHandle
(
hdb
);
res
=
MsiCloseHandle
(
hdb
);
ok
(
res
==
ERROR_SUCCESS
,
"Failed to close database
\n
"
);
ok
(
res
==
ERROR_SUCCESS
,
"Failed to close database
\n
"
);
ok
(
INVALID_FILE_ATTRIBUTES
==
GetFileAttributes
(
msifile
),
"database should exist
\n
"
);
res
=
MsiOpenDatabase
(
msifile
,
MSIDBOPEN_CREATE
,
&
hdb
);
res
=
MsiOpenDatabase
(
msifile
,
MSIDBOPEN_CREATE
,
&
hdb
);
ok
(
res
==
ERROR_SUCCESS
,
"Failed to open database
\n
"
);
ok
(
res
==
ERROR_SUCCESS
,
"Failed to open database
\n
"
);
res
=
MsiDatabaseCommit
(
hdb
);
res
=
MsiDatabaseCommit
(
hdb
);
ok
(
res
==
ERROR_SUCCESS
,
"Failed to commit database
\n
"
);
ok
(
res
==
ERROR_SUCCESS
,
"Failed to commit database
\n
"
);
ok
(
INVALID_FILE_ATTRIBUTES
!=
GetFileAttributes
(
msifile
),
"database should exist
\n
"
);
res
=
MsiCloseHandle
(
hdb
);
res
=
MsiCloseHandle
(
hdb
);
ok
(
res
==
ERROR_SUCCESS
,
"Failed to close database
\n
"
);
ok
(
res
==
ERROR_SUCCESS
,
"Failed to close database
\n
"
);
}
res
=
DeleteFile
(
msifile2
);
res
=
DeleteFile
(
msifile2
);
ok
(
res
==
TRUE
,
"Failed to delete database
\n
"
);
ok
(
res
==
TRUE
,
"Failed to delete database
\n
"
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment