winecrt0: Remove free_delay_imports.

MSVC's delayimp.lib does not actually free delayload dependencies. winecrt0's attempt to do so from ELF __attribute__((destructor)) is unnecessary and potentially harmful: - When triggered naturally via LdrUnloadDll, this leads to recursive calls to FreeLibrary, violating free_lib_count and missing DLL_PROCESS_DETACH - when triggered by glibc's _dl_fini (at process exit), it leads to use-after-free of the TEB (GetCurrentThreadID after the main thread is no longer Win32) via FreeLibrary -> LdrLdrUnloadDll -> RtlEnterCriticalSection( &loader_section ) - double-free of the library itself, since the DLL_PROCESS_DETACH has already been handled by LdrShutdownProcess - Race against wineserver sending a SIGKILL from process_killed, since all Win32 threads of the process have exited Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53032

winecrt0: Remove free_delay_imports.
b5d3759f · Kevin Puetz · Alexandre Julliard · aeb97373 · b5d3759f
Commit b5d3759f authored Aug 31, 2022 by Kevin Puetz Committed by Alexandre Julliard Aug 31, 2022
Hide whitespace changes
Inline Side-by-side

Showing with 0 additions and 10 deletions

delay_load.c dlls/winecrt0/delay_load.c +0 -10

No files found.
--- a/dlls/winecrt0/delay_load.c
+++ b/dlls/winecrt0/delay_load.c
@@ -69,14 +69,4 @@ FARPROC WINAPI DECLSPEC_HIDDEN __wine_spec_delay_load( unsigned int id )
    return proc;
 }

-#if defined(__GNUC__) && !defined(__APPLE__)  /* we can't support destructors properly on Mac OS */
-static void free_delay_imports(void) __attribute__((destructor));
-static void free_delay_imports(void)
-{
-    struct ImgDelayDescr *descr;
-    for (descr = __wine_spec_delay_imports; descr->szName; descr++)
-        if (*descr->phmod) FreeLibrary( *descr->phmod );
-}
-#endif
-
 #endif /* __WINE_PE_BUILD */