ntdll: Fix subauthority count check in RtlInitializeSid().

Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>

ntdll: Fix subauthority count check in RtlInitializeSid().
b62abc1a · Nikolay Sivov · Alexandre Julliard · af65fa04 · b62abc1a · b62abc1a
Commit b62abc1a authored May 02, 2023 by Nikolay Sivov Committed by Alexandre Julliard May 03, 2023
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 2 deletions

sec.c dlls/ntdll/sec.c +1 -1

rtl.c dlls/ntdll/tests/rtl.c +0 -1

No files found.
--- a/dlls/ntdll/sec.c
+++ b/dlls/ntdll/sec.c
@@ -303,7 +303,7 @@ NTSTATUS WINAPI RtlInitializeSid(
 	int i;
 	SID* pisid=pSid;

-	if (nSubAuthorityCount >= SID_MAX_SUB_AUTHORITIES)
+	if (nSubAuthorityCount > SID_MAX_SUB_AUTHORITIES)
 	  return STATUS_INVALID_PARAMETER;

 	pisid->Revision = SID_REVISION;

--- a/dlls/ntdll/tests/rtl.c
+++ b/dlls/ntdll/tests/rtl.c
@@ -3619,7 +3619,6 @@ static void test_RtlInitializeSid(void)
    ok(!status, "Unexpected status %#lx.\n", status);

    status = RtlInitializeSid(sid, &sid_ident, SID_MAX_SUB_AUTHORITIES);
-    todo_wine
    ok(!status, "Unexpected status %#lx.\n", status);

    status = RtlInitializeSid(sid, &sid_ident, SID_MAX_SUB_AUTHORITIES + 1);