msi: Do not attempt to copy a non-string property in MsiSummaryInfoGetProperty.

This patch fixes the crashes when running the tests under Wine. Currently the crashes are hidden by a custom action exception handler. Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru> Signed-off-by: Hans Leidekker <hans@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

msi: Do not attempt to copy a non-string property in MsiSummaryInfoGetProperty.
b857369f · Dmitry Timoshkov · Alexandre Julliard · 7929c31e · b857369f
Commit b857369f authored Sep 19, 2018 by Dmitry Timoshkov Committed by Alexandre Julliard Sep 19, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

suminfo.c dlls/msi/suminfo.c +4 -2

No files found.
--- a/dlls/msi/suminfo.c
+++ b/dlls/msi/suminfo.c
@@ -758,8 +758,10 @@ UINT WINAPI MsiSummaryInfoGetPropertyA(
        }
        __ENDTRY

-        if (!r)
+        if (!r && buf)
+        {
            r = msi_strncpyWtoA( buf, -1, szValueBuf, pcchValueBuf, TRUE );
+        }

        midl_user_free( buf );
        return r;
@@ -808,7 +810,7 @@ UINT WINAPI MsiSummaryInfoGetPropertyW(
        }
        __ENDTRY

-        if (!r)
+        if (!r && buf)
            r = msi_strncpyW( buf, -1, szValueBuf, pcchValueBuf );

        midl_user_free( buf );