hidclass.sys: Add missing case/missing HeapFree (Coverity).

Signed-off-by: Marcus Meissner <marcus@jet.franken.de> Signed-off-by: Aric Stewart <aric@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

hidclass.sys: Add missing case/missing HeapFree (Coverity).
bb590b3f · Marcus Meissner · Alexandre Julliard · 02a664c0 · bb590b3f
Commit bb590b3f authored Apr 23, 2016 by Marcus Meissner Committed by Alexandre Julliard Apr 26, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 3 deletions

pnp.c dlls/hidclass.sys/pnp.c +6 -3

No files found.
--- a/dlls/hidclass.sys/pnp.c
+++ b/dlls/hidclass.sys/pnp.c
@@ -292,10 +292,9 @@ NTSTATUS WINAPI HID_PNP_Dispatch(DEVICE_OBJECT *device, IRP *irp)
        case IRP_MN_QUERY_ID:
        {
            BASE_DEVICE_EXTENSION *ext = device->DeviceExtension;
-            ULONG type = irpsp->Parameters.QueryId.IdType;
            WCHAR *id = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(WCHAR)*REGSTR_VAL_MAX_HCID_LEN);
-            TRACE("IRP_MN_QUERY_ID[%i]\n", type);
-            switch (type)
+            TRACE("IRP_MN_QUERY_ID[%i]\n", irpsp->Parameters.QueryId.IdType);
+            switch (irpsp->Parameters.QueryId.IdType)
            {
                case BusQueryHardwareIDs:
                case BusQueryCompatibleIDs:
@@ -326,6 +325,10 @@ NTSTATUS WINAPI HID_PNP_Dispatch(DEVICE_OBJECT *device, IRP *irp)
                    irp->IoStatus.Information = (ULONG_PTR)id;
                    rc = STATUS_SUCCESS;
                    break;
+                case BusQueryDeviceSerialNumber:
+                    FIXME("BusQueryDeviceSerialNumber not implemented\n");
+                    HeapFree(GetProcessHeap(), 0, id);
+                    break;
            }
            break;
        }