msi: Remove an extraneous safety check and simplify generate_error_string().

bb8471be · Gerald Pfeifer · Alexandre Julliard · 257f519e · bb8471be
Commit bb8471be authored Jan 02, 2008 by Gerald Pfeifer Committed by Alexandre Julliard Jan 03, 2008
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 12 deletions

helpers.c dlls/msi/helpers.c +6 -12

No files found.
--- a/dlls/msi/helpers.c
+++ b/dlls/msi/helpers.c
@@ -1029,20 +1029,14 @@ WCHAR* generate_error_string(MSIPACKAGE *package, UINT error, DWORD count, ... )
    va_end(va);

    MSI_FormatRecordW(package,rec,NULL,&size);
-    if (size >= 0)
-    {
-        size++;
-        data = msi_alloc(size*sizeof(WCHAR));
-        if (size > 1)
-            MSI_FormatRecordW(package,rec,data,&size);
-        else
-            data[0] = 0;
-        msiobj_release( &rec->hdr );
-        return data;
-    }

+    size++;
+    data = msi_alloc(size*sizeof(WCHAR));
+    if (size > 1)
+        MSI_FormatRecordW(package,rec,data,&size);
+    else
+        data[0] = 0;
    msiobj_release( &rec->hdr );
-    data = NULL;
    return data;
 }