dxdiagn: Don't fail the whole initialization for invalid filter data in…

dxdiagn: Don't fail the whole initialization for invalid filter data in build_directshowfilters_tree.

dxdiagn: Don't fail the whole initialization for invalid filter data in…
bcf78a22 · Jacek Caban · Alexandre Julliard · c7332fa1 · bcf78a22
Commit bcf78a22 authored Jan 09, 2014 by Jacek Caban Committed by Alexandre Julliard Jan 09, 2014
Show whitespace changes
Inline Side-by-side

Showing with 4 additions and 3 deletions

provider.c dlls/dxdiagn/provider.c +4 -3

No files found.
--- a/dlls/dxdiagn/provider.c
+++ b/dlls/dxdiagn/provider.c
@@ -1632,16 +1632,17 @@ static HRESULT build_directshowfilters_tree(IDxDiagContainerImpl_Container *node
            }

            hr = fill_filter_container(subcont, pMoniker);
+            IMoniker_Release(pMoniker);
            if (FAILED(hr))
            {
+                WARN("Skipping invalid filter\n");
                free_information_tree(subcont);
-                IMoniker_Release(pMoniker);
-                break;
+                hr = S_OK;
+                continue;
            }

            add_subcontainer(node, subcont);
            i++;
-            IMoniker_Release(pMoniker);
        }

        IEnumMoniker_Release(pEnum);