dplayx: Fix a possible memory leak on error path (Coverity).

Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

dplayx: Fix a possible memory leak on error path (Coverity).
bd9701ad · Nikolay Sivov · Alexandre Julliard · 3acac5b2 · bd9701ad
Commit bd9701ad authored Nov 22, 2015 by Nikolay Sivov Committed by Alexandre Julliard Nov 23, 2015
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 8 deletions

dplay.c dlls/dplayx/dplay.c +3 -8

No files found.
--- a/dlls/dplayx/dplay.c
+++ b/dlls/dplayx/dplay.c
@@ -1593,17 +1593,12 @@ static HRESULT DP_IF_CreatePlayer( IDirectPlayImpl *This, void *lpMsgHdr, DPID *
     player total */
  lpPData = DP_CreatePlayer( This, lpidPlayer, lpPlayerName, dwCreateFlags,
                             hEvent, bAnsi );
-
-  if( lpPData == NULL )
-  {
-    return DPERR_CANTADDPLAYER;
-  }
-
  /* Create the list object and link it in */
  lpPList = HeapAlloc( GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof( *lpPList ) );
-  if( lpPList == NULL )
+  if( !lpPData || !lpPList )
  {
-    FIXME( "Memory leak\n" );
+    HeapFree( GetProcessHeap(), 0, lpPData );
+    HeapFree( GetProcessHeap(), 0, lpPList );
    return DPERR_CANTADDPLAYER;
  }