winegstreamer/gsttffilter: Don't drop the streaming lock in Gstreamer_transform_ProcessEnd().

This sort of reverts 096da450. The deadlock mentioned there is not spelled out in detail, but likely results from the streaming thread trying to acquire the filter lock while a main thread which is holding the filter lock waits for the streaming thread to finish. However, DirectShow documentation (and manual testing) suggests that the correct way to avoid this problem is simply to never take the filter lock from the streaming thread. Since we currently don't do this anymore, it should be safe to reinstate this lock. Signed-off-by: Zebediah Figura <z.figura12@gmail.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

winegstreamer/gsttffilter: Don't drop the streaming lock in Gstreamer_transform_ProcessEnd().
bdc09fb8 · Zebediah Figura · Alexandre Julliard · 3a7f5494 · bdc09fb8
Commit bdc09fb8 authored Nov 30, 2019 by Zebediah Figura Committed by Alexandre Julliard Dec 02, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 0 additions and 2 deletions

gsttffilter.c dlls/winegstreamer/gsttffilter.c +0 -2

No files found.
--- a/dlls/winegstreamer/gsttffilter.c
+++ b/dlls/winegstreamer/gsttffilter.c
@@ -272,9 +272,7 @@ static HRESULT WINAPI Gstreamer_transform_ProcessEnd(TransformFilter *iface)

    mark_wine_thread();

-    LeaveCriticalSection(&This->tf.csReceive);
    ret = gst_element_set_state(This->filter, GST_STATE_READY);
-    EnterCriticalSection(&This->tf.csReceive);
    TRACE("Returned: %i\n", ret);
    return S_OK;
 }