msi: Free the columns view if check_column_exists fails.

be1b1605 · James Hawkins · Alexandre Julliard · 1a4a112d · be1b1605
Commit be1b1605 authored Dec 15, 2009 by James Hawkins Committed by Alexandre Julliard Dec 16, 2009
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 0 deletions

alter.c dlls/msi/alter.c +3 -0

No files found.
--- a/dlls/msi/alter.c
+++ b/dlls/msi/alter.c
@@ -125,7 +125,10 @@ static UINT alter_add_column(MSIALTERVIEW *av)
        return r;

    if (check_column_exists(av->db, av->colinfo->table, av->colinfo->column))
+    {
+        columns->ops->delete(columns);
        return ERROR_BAD_QUERY_SYNTAX;
+    }

    r = MSI_OpenQuery(av->db, &view, query, av->colinfo->table, av->colinfo->column);
    if (r == ERROR_SUCCESS)