Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
bebc425b
Commit
bebc425b
authored
Aug 05, 2011
by
Bruno Jesus
Committed by
Alexandre Julliard
Aug 24, 2011
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
ws2_32: Fix false-positive write fds on select().
parent
6ee95c77
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
3 deletions
+4
-3
socket.c
dlls/ws2_32/socket.c
+2
-1
sock.c
dlls/ws2_32/tests/sock.c
+2
-2
No files found.
dlls/ws2_32/socket.c
View file @
bebc425b
...
@@ -3661,7 +3661,8 @@ static int get_poll_results( WS_fd_set *readfds, WS_fd_set *writefds, WS_fd_set
...
@@ -3661,7 +3661,8 @@ static int get_poll_results( WS_fd_set *readfds, WS_fd_set *writefds, WS_fd_set
if
(
writefds
)
if
(
writefds
)
{
{
for
(
i
=
k
=
0
;
i
<
writefds
->
fd_count
;
i
++
,
j
++
)
for
(
i
=
k
=
0
;
i
<
writefds
->
fd_count
;
i
++
,
j
++
)
if
(
fds
[
j
].
revents
)
writefds
->
fd_array
[
k
++
]
=
writefds
->
fd_array
[
i
];
if
((
fds
[
j
].
revents
&
POLLOUT
)
&&
!
(
fds
[
j
].
revents
&
POLLHUP
))
writefds
->
fd_array
[
k
++
]
=
writefds
->
fd_array
[
i
];
writefds
->
fd_count
=
k
;
writefds
->
fd_count
=
k
;
total
+=
k
;
total
+=
k
;
}
}
...
...
dlls/ws2_32/tests/sock.c
View file @
bebc425b
...
@@ -2311,7 +2311,7 @@ static void test_errors(void)
...
@@ -2311,7 +2311,7 @@ static void test_errors(void)
timeval
.
tv_usec
=
50000
;
timeval
.
tv_usec
=
50000
;
ret
=
select
(
1
,
NULL
,
&
set
,
NULL
,
&
timeval
);
ret
=
select
(
1
,
NULL
,
&
set
,
NULL
,
&
timeval
);
todo_wine
ok
(
(
ret
==
0
),
"expected 0 (timeout), got: %d
\n
"
,
ret
);
ok
(
(
ret
==
0
),
"expected 0 (timeout), got: %d
\n
"
,
ret
);
}
}
ret
=
closesocket
(
sock
);
ret
=
closesocket
(
sock
);
...
@@ -2353,8 +2353,8 @@ static void test_select(void)
...
@@ -2353,8 +2353,8 @@ static void test_select(void)
ret
=
select
(
maxfd
+
1
,
&
readfds
,
&
writefds
,
&
exceptfds
,
&
select_timeout
);
ret
=
select
(
maxfd
+
1
,
&
readfds
,
&
writefds
,
&
exceptfds
,
&
select_timeout
);
ok
(
(
ret
==
0
),
"select should not return any socket handles
\n
"
);
ok
(
(
ret
==
0
),
"select should not return any socket handles
\n
"
);
ok
(
!
FD_ISSET
(
fdRead
,
&
readfds
),
"FD should not be set
\n
"
);
ok
(
!
FD_ISSET
(
fdRead
,
&
readfds
),
"FD should not be set
\n
"
);
ok
(
!
FD_ISSET
(
fdWrite
,
&
writefds
),
"FD should not be set
\n
"
);
}
}
ok
(
!
FD_ISSET
(
fdWrite
,
&
writefds
),
"FD should not be set
\n
"
);
ok
(
!
FD_ISSET
(
fdRead
,
&
exceptfds
),
"FD should not be set
\n
"
);
ok
(
!
FD_ISSET
(
fdRead
,
&
exceptfds
),
"FD should not be set
\n
"
);
ok
(
!
FD_ISSET
(
fdWrite
,
&
exceptfds
),
"FD should not be set
\n
"
);
ok
(
!
FD_ISSET
(
fdWrite
,
&
exceptfds
),
"FD should not be set
\n
"
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment