strmbase/transform: Don't expose IQualityControl from the filter.

Signed-off-by: Zebediah Figura <z.figura12@gmail.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

strmbase/transform: Don't expose IQualityControl from the filter.
c1b8ffde · Zebediah Figura · Alexandre Julliard · 2a52c54f · c1b8ffde · c1b8ffde
Commit c1b8ffde authored May 18, 2019 by Zebediah Figura Committed by Alexandre Julliard May 20, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 23 deletions

acmwrapper.c dlls/quartz/tests/acmwrapper.c +1 -1

avidec.c dlls/quartz/tests/avidec.c +1 -1

transform.c dlls/strmbase/transform.c +1 -21

No files found.
--- a/dlls/quartz/tests/acmwrapper.c
+++ b/dlls/quartz/tests/acmwrapper.c
@@ -76,7 +76,7 @@ static void test_interfaces(void)
    check_interface(filter, &IID_IMediaPosition, FALSE);
    check_interface(filter, &IID_IMediaSeeking, FALSE);
    check_interface(filter, &IID_IPin, FALSE);
-    todo_wine check_interface(filter, &IID_IQualityControl, FALSE);
+    check_interface(filter, &IID_IQualityControl, FALSE);
    check_interface(filter, &IID_IQualProp, FALSE);
    check_interface(filter, &IID_IReferenceClock, FALSE);
    check_interface(filter, &IID_IVideoWindow, FALSE);

--- a/dlls/quartz/tests/avidec.c
+++ b/dlls/quartz/tests/avidec.c
@@ -101,7 +101,7 @@ static void test_interfaces(void)
    check_interface(filter, &IID_IMediaSeeking, FALSE);
    check_interface(filter, &IID_IPersistPropertyBag, FALSE);
    check_interface(filter, &IID_IPin, FALSE);
-    todo_wine check_interface(filter, &IID_IQualityControl, FALSE);
+    check_interface(filter, &IID_IQualityControl, FALSE);
    check_interface(filter, &IID_IQualProp, FALSE);
    check_interface(filter, &IID_IReferenceClock, FALSE);
    check_interface(filter, &IID_IVideoWindow, FALSE);

--- a/dlls/strmbase/transform.c
+++ b/dlls/strmbase/transform.c
@@ -161,26 +161,6 @@ static const BaseOutputPinFuncTable tf_output_BaseOutputFuncTable = {
    BaseOutputPinImpl_DecideAllocator,
 };

-static HRESULT WINAPI TransformFilterImpl_QueryInterface(IBaseFilter * iface, REFIID riid, LPVOID * ppv)
-{
-    HRESULT hr;
-    TransformFilter *This = impl_from_IBaseFilter(iface);
-    TRACE("(%p/%p)->(%s, %p)\n", This, iface, debugstr_guid(riid), ppv);
-
-    if (IsEqualIID(riid, &IID_IQualityControl))  {
-        *ppv = (IQualityControl*)This->qcimpl;
-        IUnknown_AddRef((IUnknown*)*ppv);
-        return S_OK;
-    }
-    hr = BaseFilterImpl_QueryInterface(iface, riid, ppv);
-
-    if (FAILED(hr) && !IsEqualIID(riid, &IID_IPin) && !IsEqualIID(riid, &IID_IVideoWindow) &&
-        !IsEqualIID(riid, &IID_IAMFilterMiscFlags))
-        FIXME("No interface for %s!\n", debugstr_guid(riid));
-
-    return hr;
-}
-
 static ULONG WINAPI TransformFilterImpl_Release(IBaseFilter * iface)
 {
    TransformFilter *This = impl_from_IBaseFilter(iface);
@@ -293,7 +273,7 @@ static HRESULT WINAPI TransformFilterImpl_Run(IBaseFilter *iface, REFERENCE_TIME

 static const IBaseFilterVtbl transform_vtbl =
 {
-    TransformFilterImpl_QueryInterface,
+    BaseFilterImpl_QueryInterface,
    BaseFilterImpl_AddRef,
    TransformFilterImpl_Release,
    BaseFilterImpl_GetClassID,