Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
c3db8982
Commit
c3db8982
authored
Oct 28, 2018
by
Zebediah Figura
Committed by
Alexandre Julliard
Oct 30, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
rpcrt4: Add comments explaining the arguments to EmbeddedPointerUnmarshall().
Signed-off-by:
Zebediah Figura
<
z.figura12@gmail.com
>
Signed-off-by:
Alexandre Julliard
<
julliard@winehq.org
>
parent
60c06980
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
11 additions
and
6 deletions
+11
-6
ndr_marshall.c
dlls/rpcrt4/ndr_marshall.c
+11
-6
No files found.
dlls/rpcrt4/ndr_marshall.c
View file @
c3db8982
...
...
@@ -856,9 +856,9 @@ static void PointerMarshall(PMIDL_STUB_MESSAGE pStubMsg,
STD_OVERFLOW_CHECK
(
pStubMsg
);
}
/*
**********************************************************************
*
PointerUnmarshall [internal]
*/
/*
pPointer is the pointer that we will unmarshal into; pSrcPointer is the
*
pointer to memory which we may attempt to reuse if non-NULL. Usually these
*
are the same; for the case when they aren't, see EmbeddedPointerUnmarshall(). *
/
static
void
PointerUnmarshall
(
PMIDL_STUB_MESSAGE
pStubMsg
,
unsigned
char
*
Buffer
,
unsigned
char
**
pPointer
,
...
...
@@ -1228,9 +1228,14 @@ static unsigned char * EmbeddedPointerMarshall(PMIDL_STUB_MESSAGE pStubMsg,
return
NULL
;
}
/***********************************************************************
* EmbeddedPointerUnmarshall
*/
/* rpcrt4 does something bizarre with embedded pointers: instead of copying the
* struct/array/union from the buffer to memory and then unmarshalling pointers
* into it, it unmarshals pointers into the buffer itself and then copies it to
* memory. However, it will still attempt to use a user-supplied pointer where
* appropriate (i.e. one on stack). Therefore we need to pass both pointers to
* this function and to PointerUnmarshall: the pointer (to the buffer) that we
* will actually unmarshal into (pDstBuffer), and the pointer (to memory) that
* we will attempt to use for storage if possible (pSrcMemoryPtrs). */
static
unsigned
char
*
EmbeddedPointerUnmarshall
(
PMIDL_STUB_MESSAGE
pStubMsg
,
unsigned
char
*
pDstBuffer
,
unsigned
char
*
pSrcMemoryPtrs
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment