Commit c577c27e authored by Lionel Ulmer's avatar Lionel Ulmer Committed by Alexandre Julliard

No need to flush the surface back if last lock was a RO lock.

parent 9bf3ac61
...@@ -112,7 +112,7 @@ static BOOL opengl_flip( LPVOID dev, LPVOID drawable) ...@@ -112,7 +112,7 @@ static BOOL opengl_flip( LPVOID dev, LPVOID drawable)
TRACE("(%p, %ld)\n", gl_d3d_dev->display,(Drawable)drawable); TRACE("(%p, %ld)\n", gl_d3d_dev->display,(Drawable)drawable);
ENTER_GL(); ENTER_GL();
if (gl_d3d_dev->state == SURFACE_MEMORY) { if (gl_d3d_dev->state == SURFACE_MEMORY_DIRTY) {
d3d_dev->flush_to_framebuffer(d3d_dev, NULL); d3d_dev->flush_to_framebuffer(d3d_dev, NULL);
} }
gl_d3d_dev->state = SURFACE_GL; gl_d3d_dev->state = SURFACE_GL;
...@@ -1127,7 +1127,7 @@ static void draw_primitive_strided(IDirect3DDeviceImpl *This, ...@@ -1127,7 +1127,7 @@ static void draw_primitive_strided(IDirect3DDeviceImpl *This,
int num_active_stages = 0; int num_active_stages = 0;
ENTER_GL(); ENTER_GL();
if (glThis->state == SURFACE_MEMORY) { if (glThis->state == SURFACE_MEMORY_DIRTY) {
This->flush_to_framebuffer(This, NULL); This->flush_to_framebuffer(This, NULL);
} }
LEAVE_GL(); LEAVE_GL();
...@@ -2431,6 +2431,7 @@ static HRESULT d3ddevice_clear(IDirect3DDeviceImpl *This, ...@@ -2431,6 +2431,7 @@ static HRESULT d3ddevice_clear(IDirect3DDeviceImpl *This,
D3DVALUE dvZ, D3DVALUE dvZ,
DWORD dwStencil) DWORD dwStencil)
{ {
IDirect3DDeviceGLImpl *glThis = (IDirect3DDeviceGLImpl *) This;
GLboolean ztest; GLboolean ztest;
GLfloat old_z_clear_value; GLfloat old_z_clear_value;
GLbitfield bitfield = 0; GLbitfield bitfield = 0;
...@@ -2462,6 +2463,13 @@ static HRESULT d3ddevice_clear(IDirect3DDeviceImpl *This, ...@@ -2462,6 +2463,13 @@ static HRESULT d3ddevice_clear(IDirect3DDeviceImpl *This,
/* Clears the screen */ /* Clears the screen */
ENTER_GL(); ENTER_GL();
if (glThis->state == SURFACE_MEMORY_DIRTY) {
/* TODO: optimize here the case where Clear changes all the screen... */
This->flush_to_framebuffer(This, NULL);
}
glThis->state = SURFACE_GL;
if (dwFlags & D3DCLEAR_ZBUFFER) { if (dwFlags & D3DCLEAR_ZBUFFER) {
bitfield |= GL_DEPTH_BUFFER_BIT; bitfield |= GL_DEPTH_BUFFER_BIT;
glGetBooleanv(GL_DEPTH_WRITEMASK, &ztest); glGetBooleanv(GL_DEPTH_WRITEMASK, &ztest);
...@@ -2740,8 +2748,8 @@ static void d3ddevice_lock_update(IDirectDrawSurfaceImpl* This, LPCRECT pRect, D ...@@ -2740,8 +2748,8 @@ static void d3ddevice_lock_update(IDirectDrawSurfaceImpl* This, LPCRECT pRect, D
/* Try to acquire the device critical section */ /* Try to acquire the device critical section */
EnterCriticalSection(&(d3d_dev->crit)); EnterCriticalSection(&(d3d_dev->crit));
if (((is_front == TRUE) && (gl_d3d_dev->front_state != SURFACE_MEMORY)) || if (((is_front == TRUE) && (gl_d3d_dev->front_state == SURFACE_GL)) ||
((is_front == FALSE) && (gl_d3d_dev->state != SURFACE_MEMORY))) { ((is_front == FALSE) && (gl_d3d_dev->state == SURFACE_GL))) {
/* If the surface is already in memory, no need to do anything here... */ /* If the surface is already in memory, no need to do anything here... */
GLenum buffer_type; GLenum buffer_type;
GLenum buffer_color; GLenum buffer_color;
...@@ -2991,6 +2999,7 @@ static void d3ddevice_unlock_update(IDirectDrawSurfaceImpl* This, LPCRECT pRect) ...@@ -2991,6 +2999,7 @@ static void d3ddevice_unlock_update(IDirectDrawSurfaceImpl* This, LPCRECT pRect)
{ {
BOOLEAN is_front; BOOLEAN is_front;
IDirect3DDeviceImpl *d3d_dev = This->d3ddevice; IDirect3DDeviceImpl *d3d_dev = This->d3ddevice;
IDirect3DDeviceGLImpl* gl_d3d_dev = (IDirect3DDeviceGLImpl*) d3d_dev;
if ((This->surface_desc.ddsCaps.dwCaps & (DDSCAPS_FRONTBUFFER|DDSCAPS_PRIMARYSURFACE)) != 0) { if ((This->surface_desc.ddsCaps.dwCaps & (DDSCAPS_FRONTBUFFER|DDSCAPS_PRIMARYSURFACE)) != 0) {
is_front = TRUE; is_front = TRUE;
...@@ -3001,8 +3010,8 @@ static void d3ddevice_unlock_update(IDirectDrawSurfaceImpl* This, LPCRECT pRect) ...@@ -3001,8 +3010,8 @@ static void d3ddevice_unlock_update(IDirectDrawSurfaceImpl* This, LPCRECT pRect)
return; return;
} }
/* First, check if we need to do anything. For the backbuffer, flushing is done at the next 3D activity. */ /* First, check if we need to do anything. For the backbuffer, flushing is done at the next 3D activity. */
if (((This->lastlocktype & DDLOCK_READONLY) == 0) && if ((This->lastlocktype & DDLOCK_READONLY) == 0) {
(is_front == TRUE)) { if (is_front == TRUE) {
GLenum prev_draw; GLenum prev_draw;
ENTER_GL(); ENTER_GL();
glGetIntegerv(GL_DRAW_BUFFER, &prev_draw); glGetIntegerv(GL_DRAW_BUFFER, &prev_draw);
...@@ -3010,6 +3019,9 @@ static void d3ddevice_unlock_update(IDirectDrawSurfaceImpl* This, LPCRECT pRect) ...@@ -3010,6 +3019,9 @@ static void d3ddevice_unlock_update(IDirectDrawSurfaceImpl* This, LPCRECT pRect)
d3d_dev->flush_to_framebuffer(d3d_dev, pRect); d3d_dev->flush_to_framebuffer(d3d_dev, pRect);
glDrawBuffer(prev_draw); glDrawBuffer(prev_draw);
LEAVE_GL(); LEAVE_GL();
} else {
gl_d3d_dev->state = SURFACE_MEMORY_DIRTY;
}
} }
/* And 'frees' the device critical section */ /* And 'frees' the device critical section */
......
...@@ -207,7 +207,7 @@ static void execute(IDirect3DExecuteBufferImpl *This, ...@@ -207,7 +207,7 @@ static void execute(IDirect3DExecuteBufferImpl *This,
ENTER_GL(); ENTER_GL();
if (((IDirect3DDeviceGLImpl *) lpDevice)->state == SURFACE_MEMORY) { if (((IDirect3DDeviceGLImpl *) lpDevice)->state == SURFACE_MEMORY_DIRTY) {
lpDevice->flush_to_framebuffer(lpDevice, NULL); lpDevice->flush_to_framebuffer(lpDevice, NULL);
} }
((IDirect3DDeviceGLImpl *) lpDevice)->state = SURFACE_GL; ((IDirect3DDeviceGLImpl *) lpDevice)->state = SURFACE_GL;
......
...@@ -100,7 +100,8 @@ typedef enum { ...@@ -100,7 +100,8 @@ typedef enum {
typedef enum { typedef enum {
SURFACE_GL, SURFACE_GL,
SURFACE_MEMORY SURFACE_MEMORY,
SURFACE_MEMORY_DIRTY
} SURFACE_STATE; } SURFACE_STATE;
typedef struct IDirect3DDeviceGLImpl typedef struct IDirect3DDeviceGLImpl
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment