Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
c6dbb33e
Commit
c6dbb33e
authored
Apr 21, 2014
by
Dmitry Timoshkov
Committed by
Alexandre Julliard
Apr 21, 2014
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
user32: When converting from MF_ flags to MENUITEMINFO ignore MF_POPUP if id is not a menu.
parent
7744c700
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
1 addition
and
7 deletions
+1
-7
menu.c
dlls/user32/menu.c
+1
-1
menu.c
dlls/user32/tests/menu.c
+0
-6
No files found.
dlls/user32/menu.c
View file @
c6dbb33e
...
...
@@ -3859,7 +3859,7 @@ static void MENU_mnu2mnuii( UINT flags, UINT_PTR id, LPCWSTR str,
pmii
->
fMask
|=
MIIM_DATA
;
pmii
->
dwItemData
=
(
ULONG_PTR
)
str
;
}
if
(
flags
&
MF_POPUP
)
{
if
(
flags
&
MF_POPUP
&&
MENU_GetMenu
((
HMENU
)
id
)
)
{
pmii
->
fMask
|=
MIIM_SUBMENU
;
pmii
->
hSubMenu
=
(
HMENU
)
id
;
}
...
...
dlls/user32/tests/menu.c
View file @
c6dbb33e
...
...
@@ -3639,18 +3639,14 @@ static void test_AppendMenu(void)
hmenu
=
CreateMenu
();
ok
(
hmenu
!=
0
,
"CreateMenu failed
\n
"
);
ret
=
AppendMenuA
(
hmenu
,
MF_POPUP
,
202
,
"item 1"
);
todo_wine
ok
(
ret
,
"AppendMenu failed
\n
"
);
if
(
ret
)
/* FIXME: uncomment once Wine is fixed */
check_menu_items
(
hmenu
,
202
,
MF_STRING
,
0
);
DestroyMenu
(
hmenu
);
hmenu
=
CreateMenu
();
ok
(
hmenu
!=
0
,
"CreateMenu failed
\n
"
);
ret
=
AppendMenuA
(
hmenu
,
MF_OWNERDRAW
|
MF_POPUP
,
203
,
"item 1"
);
todo_wine
ok
(
ret
,
"AppendMenu failed
\n
"
);
if
(
ret
)
/* FIXME: uncomment once Wine is fixed */
check_menu_items
(
hmenu
,
203
,
MF_OWNERDRAW
,
0
);
DestroyMenu
(
hmenu
);
...
...
@@ -3720,9 +3716,7 @@ if (ret) /* FIXME: uncomment once Wine is fixed */
ok
(
ret
,
"AppendMenu failed
\n
"
);
check_menu_items
(
hmenu
,
204
,
MF_STRING
,
0
);
ret
=
ModifyMenuA
(
hmenu
,
0
,
MF_POPUP
|
MF_BYPOSITION
,
205
,
"item 2"
);
todo_wine
ok
(
ret
,
"ModifyMenu failed
\n
"
);
if
(
ret
)
/* FIXME: uncomment once Wine is fixed */
check_menu_items
(
hmenu
,
205
,
MF_STRING
,
0
);
memset
(
&
mii
,
0
,
sizeof
(
mii
));
mii
.
cbSize
=
sizeof
(
mii
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment