Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
c7ad47e9
Commit
c7ad47e9
authored
Feb 09, 2017
by
Jacob Lifshay
Committed by
Alexandre Julliard
Feb 13, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
kernel32: Fix improper escaping of quotes in command line.
Signed-off-by:
Jacob Lifshay
<
programmerjake@gmail.com
>
Signed-off-by:
Alexandre Julliard
<
julliard@winehq.org
>
parent
f353e425
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
14 additions
and
5 deletions
+14
-5
process.c
dlls/kernel32/process.c
+14
-5
No files found.
dlls/kernel32/process.c
View file @
c7ad47e9
...
...
@@ -745,6 +745,10 @@ static void update_library_argv0( const WCHAR *argv0 )
* resulting in an odd number of '\' followed by a '"'
* '\"' -> '\\\"'
* '\\"' -> '\\\\\"'
* - '\'s are followed by the closing '"' must be doubled,
* resulting in an even number of '\' followed by a '"'
* ' \' -> '" \\"'
* ' \\' -> '" \\\\"'
* - '\'s that are not followed by a '"' can be left as is
* 'a\b' == 'a\b'
* 'a\\b' == 'a\\b'
...
...
@@ -787,7 +791,7 @@ static BOOL build_command_line( WCHAR **argv )
}
len
+=
(
a
-*
arg
)
+
1
/* for the separating space */
;
if
(
has_space
)
len
+=
2
;
/* for the quotes
*/
len
+=
2
+
bcount
;
/* for the quotes and doubling of '\' preceding the closing quote
*/
}
if
(
!
(
rupp
->
CommandLine
.
Buffer
=
RtlAllocateHeap
(
GetProcessHeap
(),
0
,
len
*
sizeof
(
WCHAR
))))
...
...
@@ -800,6 +804,7 @@ static BOOL build_command_line( WCHAR **argv )
{
BOOL
has_space
,
has_quote
;
WCHAR
*
a
;
int
bcount
;
/* Check for quotes and spaces in this argument */
has_space
=
has_quote
=
FALSE
;
...
...
@@ -821,9 +826,7 @@ static BOOL build_command_line( WCHAR **argv )
/* Now transfer it to the command line */
if
(
has_space
)
*
p
++=
'"'
;
if
(
has_quote
)
{
int
bcount
;
if
(
has_quote
||
has_space
)
{
bcount
=
0
;
a
=*
arg
;
while
(
*
a
!=
'\0'
)
{
...
...
@@ -849,8 +852,14 @@ static BOOL build_command_line( WCHAR **argv )
WCHAR
*
x
=
*
arg
;
while
((
*
p
=*
x
++
))
p
++
;
}
if
(
has_space
)
if
(
has_space
)
{
int
i
;
/* Double all the '\' preceding the closing quote */
for
(
i
=
0
;
i
<
bcount
;
i
++
)
*
p
++=
'\\'
;
*
p
++=
'"'
;
}
*
p
++=
' '
;
}
if
(
p
>
rupp
->
CommandLine
.
Buffer
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment