msi: Get rid of the goto in MSI_ApplicablePatchW.

c815432a · Hans Leidekker · Alexandre Julliard · 0a498428 · c815432a
Commit c815432a authored May 25, 2010 by Hans Leidekker Committed by Alexandre Julliard May 25, 2010
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 3 deletions

msi.c dlls/msi/msi.c +2 -3

No files found.
--- a/dlls/msi/msi.c
+++ b/dlls/msi/msi.c
@@ -541,15 +541,14 @@ static UINT MSI_ApplicablePatchW( MSIPACKAGE *package, LPCWSTR patch )
    si = MSI_GetSummaryInformationW( patch_db->storage, 0 );
    if (!si)
    {
-        r = ERROR_FUNCTION_FAILED;
+        msiobj_release( &patch_db->hdr );
-        goto done;
+        return ERROR_FUNCTION_FAILED;
    }
    r = msi_check_patch_applicable( package, si );
    if (r != ERROR_SUCCESS)
        TRACE("patch not applicable\n");
-done:
    msiobj_release( &patch_db->hdr );
    msiobj_release( &si->hdr );
    return r;