Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
cd616409
Commit
cd616409
authored
Dec 08, 2008
by
Paul Chitescu
Committed by
Alexandre Julliard
Dec 09, 2008
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
shell32.dll: Return SE_ERR_FNF if file not found before checking for associations.
parent
23456b69
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
10 additions
and
4 deletions
+10
-4
shlexec.c
dlls/shell32/shlexec.c
+6
-0
shlexec.c
dlls/shell32/tests/shlexec.c
+4
-4
No files found.
dlls/shell32/shlexec.c
View file @
cd616409
...
@@ -588,6 +588,12 @@ static UINT SHELL_FindExecutable(LPCWSTR lpPath, LPCWSTR lpFile, LPCWSTR lpOpera
...
@@ -588,6 +588,12 @@ static UINT SHELL_FindExecutable(LPCWSTR lpPath, LPCWSTR lpFile, LPCWSTR lpOpera
}
}
else
else
{
{
/* Did we get something? Anything? */
if
(
xlpFile
[
0
]
==
0
)
{
TRACE
(
"Returning SE_ERR_FNF
\n
"
);
return
SE_ERR_FNF
;
}
/* First thing we need is the file's extension */
/* First thing we need is the file's extension */
extension
=
strrchrW
(
xlpFile
,
'.'
);
/* Assume last "." is the one; */
extension
=
strrchrW
(
xlpFile
,
'.'
);
/* Assume last "." is the one; */
/* File->Run in progman uses */
/* File->Run in progman uses */
...
...
dlls/shell32/tests/shlexec.c
View file @
cd616409
...
@@ -627,8 +627,8 @@ typedef struct
...
@@ -627,8 +627,8 @@ typedef struct
static
filename_tests_t
filename_tests
[]
=
static
filename_tests_t
filename_tests
[]
=
{
{
/* Test bad / nonexistent filenames */
/* Test bad / nonexistent filenames */
{
NULL
,
"%s
\\
nonexistent.shlexec"
,
0x
11
,
SE_ERR_FNF
},
{
NULL
,
"%s
\\
nonexistent.shlexec"
,
0x
0
,
SE_ERR_FNF
},
{
NULL
,
"%s
\\
nonexistent.noassoc"
,
0x
11
,
SE_ERR_FNF
},
{
NULL
,
"%s
\\
nonexistent.noassoc"
,
0x
0
,
SE_ERR_FNF
},
/* Standard tests */
/* Standard tests */
{
NULL
,
"%s
\\
test file.shlexec"
,
0x0
,
33
},
{
NULL
,
"%s
\\
test file.shlexec"
,
0x0
,
33
},
...
@@ -644,7 +644,7 @@ static filename_tests_t filename_tests[]=
...
@@ -644,7 +644,7 @@ static filename_tests_t filename_tests[]=
{
NULL
,
"%s
\\
test file.shlexec.noassoc"
,
0x0
,
SE_ERR_NOASSOC
},
{
NULL
,
"%s
\\
test file.shlexec.noassoc"
,
0x0
,
SE_ERR_NOASSOC
},
/* Test alternate verbs */
/* Test alternate verbs */
{
"LowerL"
,
"%s
\\
nonexistent.shlexec"
,
0x
11
,
SE_ERR_FNF
},
{
"LowerL"
,
"%s
\\
nonexistent.shlexec"
,
0x
0
,
SE_ERR_FNF
},
{
"LowerL"
,
"%s
\\
test file.noassoc"
,
0x0
,
SE_ERR_NOASSOC
},
{
"LowerL"
,
"%s
\\
test file.noassoc"
,
0x0
,
SE_ERR_NOASSOC
},
{
"QuotedLowerL"
,
"%s
\\
test file.shlexec"
,
0x0
,
33
},
{
"QuotedLowerL"
,
"%s
\\
test file.shlexec"
,
0x0
,
33
},
...
@@ -868,7 +868,7 @@ static void test_find_executable(void)
...
@@ -868,7 +868,7 @@ static void test_find_executable(void)
ok
(
rc
>
32
,
"FindExecutable(%s) returned %d
\n
"
,
filename
,
rc
);
ok
(
rc
>
32
,
"FindExecutable(%s) returned %d
\n
"
,
filename
,
rc
);
rc
=
(
int
)
FindExecutableA
(
"test file.sfe"
,
NULL
,
command
);
rc
=
(
int
)
FindExecutableA
(
"test file.sfe"
,
NULL
,
command
);
todo_wine
ok
(
rc
==
SE_ERR_FNF
,
"FindExecutable(%s) returned %d
\n
"
,
filename
,
rc
);
ok
(
rc
==
SE_ERR_FNF
,
"FindExecutable(%s) returned %d
\n
"
,
filename
,
rc
);
delete_test_association
(
".sfe"
);
delete_test_association
(
".sfe"
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment