Commit ce71f5a0 authored by Nikolay Sivov's avatar Nikolay Sivov Committed by Alexandre Julliard

evr/sample: Avoid a race condition when releasing a tracked sample.

parent 1d7d3f58
...@@ -920,19 +920,21 @@ static ULONG WINAPI video_sample_AddRef(IMFSample *iface) ...@@ -920,19 +920,21 @@ static ULONG WINAPI video_sample_AddRef(IMFSample *iface)
static ULONG WINAPI video_sample_Release(IMFSample *iface) static ULONG WINAPI video_sample_Release(IMFSample *iface)
{ {
struct video_sample *sample = impl_from_IMFSample(iface); struct video_sample *sample = impl_from_IMFSample(iface);
ULONG refcount; ULONG refcount = InterlockedDecrement(&sample->refcount);
IMFAsyncResult *tracked_result = NULL;
IMFSample_LockStore(sample->sample); IMFSample_LockStore(sample->sample);
if (sample->tracked_result && sample->tracked_refcount == (sample->refcount - 1)) if (sample->tracked_result && sample->tracked_refcount == refcount)
{ {
video_sample_tracking_thread_invoke(sample->tracked_result); tracked_result = sample->tracked_result;
IMFAsyncResult_Release(sample->tracked_result); video_sample_tracking_thread_invoke(tracked_result);
sample->tracked_result = NULL; sample->tracked_result = NULL;
sample->tracked_refcount = 0; sample->tracked_refcount = 0;
} }
IMFSample_UnlockStore(sample->sample); IMFSample_UnlockStore(sample->sample);
refcount = InterlockedDecrement(&sample->refcount); if (tracked_result)
IMFAsyncResult_Release(tracked_result);
TRACE("%p, refcount %lu.\n", iface, refcount); TRACE("%p, refcount %lu.\n", iface, refcount);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment