Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
cf5d9848
Commit
cf5d9848
authored
Jul 12, 2015
by
Nikolay Sivov
Committed by
Alexandre Julliard
Jul 13, 2015
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
dwrite: Check GetGdiCompatibleMetrics() return value (Coverity).
parent
66efbbba
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
3 deletions
+9
-3
analyzer.c
dlls/dwrite/analyzer.c
+6
-1
layout.c
dlls/dwrite/layout.c
+3
-2
No files found.
dlls/dwrite/analyzer.c
View file @
cf5d9848
...
@@ -1090,7 +1090,12 @@ static HRESULT WINAPI dwritetextanalyzer_GetGdiCompatibleGlyphPlacements(IDWrite
...
@@ -1090,7 +1090,12 @@ static HRESULT WINAPI dwritetextanalyzer_GetGdiCompatibleGlyphPlacements(IDWrite
return
hr
;
return
hr
;
}
}
IDWriteFontFace_GetGdiCompatibleMetrics
(
fontface
,
emSize
,
pixels_per_dip
,
transform
,
&
metrics
);
hr
=
IDWriteFontFace_GetGdiCompatibleMetrics
(
fontface
,
emSize
,
pixels_per_dip
,
transform
,
&
metrics
);
if
(
FAILED
(
hr
))
{
IDWriteFontFace1_Release
(
fontface1
);
WARN
(
"failed to get compat metrics, 0x%08x
\n
"
,
hr
);
return
hr
;
}
for
(
i
=
0
;
i
<
glyph_count
;
i
++
)
{
for
(
i
=
0
;
i
<
glyph_count
;
i
++
)
{
INT32
a
;
INT32
a
;
...
...
dlls/dwrite/layout.c
View file @
cf5d9848
...
@@ -828,12 +828,13 @@ static HRESULT layout_compute_runs(struct dwrite_textlayout *layout)
...
@@ -828,12 +828,13 @@ static HRESULT layout_compute_runs(struct dwrite_textlayout *layout)
/* baseline derived from font metrics */
/* baseline derived from font metrics */
if
(
layout
->
gdicompatible
)
{
if
(
layout
->
gdicompatible
)
{
/* FIXME: check return value when it's actually implemented */
hr
=
IDWriteFontFace_GetGdiCompatibleMetrics
(
run
->
run
.
fontFace
,
IDWriteFontFace_GetGdiCompatibleMetrics
(
run
->
run
.
fontFace
,
run
->
run
.
fontEmSize
,
run
->
run
.
fontEmSize
,
layout
->
pixels_per_dip
,
layout
->
pixels_per_dip
,
&
layout
->
transform
,
&
layout
->
transform
,
&
fontmetrics
);
&
fontmetrics
);
if
(
FAILED
(
hr
))
WARN
(
"failed to get compat metrics, 0x%08x
\n
"
,
hr
);
}
}
else
else
IDWriteFontFace_GetMetrics
(
run
->
run
.
fontFace
,
&
fontmetrics
);
IDWriteFontFace_GetMetrics
(
run
->
run
.
fontFace
,
&
fontmetrics
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment