msxml3: Handle SafeArrayAccessData() failure in load() (Coverity).

cfe52abc · Nikolay Sivov · Alexandre Julliard · 27b7ff73 · cfe52abc
Commit cfe52abc authored Jun 14, 2015 by Nikolay Sivov Committed by Alexandre Julliard Jun 15, 2015
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 1 deletion

domdoc.c dlls/msxml3/domdoc.c +7 -1

No files found.
--- a/dlls/msxml3/domdoc.c
+++ b/dlls/msxml3/domdoc.c
@@ -2140,7 +2140,13 @@ static HRESULT WINAPI domdoc_load(
            case 1:
                /* Only takes UTF-8 strings.
                 * NOT NULL-terminated. */
-                SafeArrayAccessData(psa, (void**)&str);
+                hr = SafeArrayAccessData(psa, (void**)&str);
+                if (FAILED(hr))
+                {
+                    This->error = hr;
+                    WARN("failed to access array data, 0x%08x\n", hr);
+                    break;
+                }
                SafeArrayGetUBound(psa, 1, &len);

                if ((xmldoc = doparse(This, str, ++len, XML_CHAR_ENCODING_UTF8)))