d3dx9: Avoid double free on effect initialization failure.

Signed-off-by: Matteo Bruni <mbruni@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

d3dx9: Avoid double free on effect initialization failure.
cffe3548 · Matteo Bruni · Alexandre Julliard · c8e195e1 · cffe3548
Commit cffe3548 authored Mar 18, 2019 by Matteo Bruni Committed by Alexandre Julliard Mar 18, 2019
Show whitespace changes
Inline Side-by-side

Showing with 0 additions and 1 deletion

effect.c dlls/d3dx9_36/effect.c +0 -1

No files found.
--- a/dlls/d3dx9_36/effect.c
+++ b/dlls/d3dx9_36/effect.c
@@ -6303,7 +6303,6 @@ static HRESULT d3dx9_base_effect_init(struct d3dx9_base_effect *base,
                            debugstr_a(skip_constants[i]), j);
                    HeapFree(GetProcessHeap(), 0, skip_constants_buffer);
                    HeapFree(GetProcessHeap(), 0, skip_constants);
-                    d3dx9_base_effect_cleanup(effect);
                    return D3DERR_INVALIDCALL;
                }
            }